Skip to content

The footer and header margin prop is wrongly typed #1710

@GomezIvann

Description

@GomezIvann

The prop margin in the Footer component accepts both an object and a string from the range of values. Since the value is only applied to the margin-top of the container, we need to change both the type and the implementation to only accept strings. An object doesn't make any sense here.

It also happens in the Header with the margin-bottom. There the type is correct but we need to consider renaming the prop to marginBottom.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingjiraThis task is referenced in a story of Jira

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions