Skip to content

Commit fb44418

Browse files
authored
Merge pull request #2330 from dxc-technology/PelayoFelgueroso/breadcrumbs-fix
Fix preventDefult on Breadcrumbs item
2 parents a54ef73 + 13ea036 commit fb44418

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

apps/website/screens/components/breadcrumbs/code/examples/basicUsage.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ const code = `() => {
77
href: "/components/select",
88
},
99
{
10-
label: "Specifications",
11-
href: "/components/select/specifications",
10+
label: "Code",
11+
href: "/components/select/code",
1212
},
1313
{
14-
label: "Design Tokens",
15-
href: "/components/select/specifications/#design-tokens",
14+
label: "Examples",
15+
href: "/components/select/code/#examples",
1616
},
1717
{
18-
label: "Color",
18+
label: "Uncontrolled",
1919
}
2020
];
2121

apps/website/screens/components/breadcrumbs/code/examples/nextJS.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ const code = `() => {
1313
href: "/components/select",
1414
},
1515
{
16-
label: "Specifications",
17-
href: "/components/select/specifications",
16+
label: "Code",
17+
href: "/components/select/code",
1818
},
1919
{
20-
label: "Design Tokens",
21-
href: "/components/select/specifications/#design-tokens",
20+
label: "Examples",
21+
href: "/components/select/code/#examples",
2222
},
2323
{
24-
label: "Color",
24+
label: "Uncontrolled",
2525
}
2626
];
2727

packages/lib/src/breadcrumbs/Item.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,9 @@ const Item = ({ isCurrentPage = false, href, label, onClick }: ItemPropsType) =>
4848
const currentItemRef = useRef<HTMLSpanElement | null>(null);
4949

5050
const handleOnClick = (event: MouseEvent<HTMLAnchorElement>) => {
51+
if (typeof onClick !== "function") return;
5152
event.preventDefault();
52-
if (href) onClick?.(href);
53+
if (href) onClick(href);
5354
};
5455

5556
const handleOnMouseEnter = (event: MouseEvent<HTMLAnchorElement>) => {

0 commit comments

Comments
 (0)