Skip to content

Commit d966804

Browse files
authored
Merge pull request #1236 from dxc-technology/marcialfps-issue-1218
[Patch] Link with icon inline with text
2 parents 3ddd593 + d09765f commit d966804

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

lib/src/link/Link.stories.tsx

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,18 @@ export const Chromatic = () => (
6868
</ExampleContainer>
6969
<ExampleContainer pseudoState="pseudo-hover">
7070
<Title title="Long text with hover" theme="light" level={4} />
71-
Lorem <DxcLink href="https://www.google.com">Test</DxcLink> ipsum dolor sit amet, consectetur adipiscing elit, sed
72-
do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation
73-
ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit
74-
esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui
75-
officia deserunt mollit anim id est laborum.
71+
Lorem{" "}
72+
<DxcLink href="https://www.google.com" icon={icon}>
73+
Test
74+
</DxcLink>{" "}
75+
ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna
76+
aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo
77+
consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
78+
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit{" "}
79+
<DxcLink href="https://www.google.com" icon={icon} iconPosition="after">
80+
Test
81+
</DxcLink>{" "}
82+
anim id est laborum.
7683
</ExampleContainer>
7784
<ExampleContainer pseudoState="pseudo-focus">
7885
<Title title="Long text with focus" theme="light" level={4} />

lib/src/link/Link.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ type StyledLinkProps = {
6565
};
6666
const StyledLink = styled.div<StyledLinkProps>`
6767
display: inline-flex;
68+
align-items: baseline;
69+
6870
margin: ${(props) => (props.margin && typeof props.margin !== "object" ? spaces[props.margin] : "0px")};
6971
margin-top: ${(props) =>
7072
props.margin && typeof props.margin === "object" && props.margin.top ? spaces[props.margin.top] : ""};

0 commit comments

Comments
 (0)