Skip to content

Commit d28536a

Browse files
authored
Merge pull request #1991 from dxc-technology/Mil4n0r/tooltip-application_layout
Added custom tooltip to `ApplicationLayout`
2 parents 9559292 + 7e0ab31 commit d28536a

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

packages/lib/src/common/variables.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1357,7 +1357,7 @@ export const defaultTranslatedComponentLabels = {
13571357
logoAlternativeText: "Logo",
13581358
},
13591359
applicationLayout: {
1360-
visibilityToggleTitle: "Toggle visibility sidenav",
1360+
visibilityToggleTitle: "Toggle sidenav visibility",
13611361
},
13621362
alert: {
13631363
infoTitleText: "information",

packages/lib/src/layout/ApplicationLayout.tsx

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import DxcIcon from "../icon/Icon";
77
import DxcSidenav from "../sidenav/Sidenav";
88
import { SidenavContextProvider, useResponsiveSidenavVisibility } from "../sidenav/SidenavContext";
99
import useTranslatedLabels from "../useTranslatedLabels";
10+
import DxcTooltip from "../tooltip/Tooltip";
1011
import layoutIcons from "./Icons";
1112
import AppLayoutPropsType, { AppLayoutMainPropsType } from "./types";
1213

@@ -100,14 +101,15 @@ const DxcApplicationLayout = ({
100101
<HeaderContainer>{headerContent}</HeaderContainer>
101102
{sidenav && isResponsive && (
102103
<VisibilityToggle>
103-
<HamburgerTrigger
104-
onClick={handleSidenavVisibility}
105-
aria-label={visibilityToggleLabel ? undefined : translatedLabels.applicationLayout.visibilityToggleTitle}
106-
title={translatedLabels.applicationLayout.visibilityToggleTitle}
107-
>
108-
<DxcIcon icon="Menu" />
109-
{visibilityToggleLabel}
110-
</HamburgerTrigger>
104+
<DxcTooltip label={translatedLabels.applicationLayout.visibilityToggleTitle}>
105+
<HamburgerTrigger
106+
onClick={handleSidenavVisibility}
107+
aria-label={visibilityToggleLabel ? undefined : translatedLabels.applicationLayout.visibilityToggleTitle}
108+
>
109+
<DxcIcon icon="Menu" />
110+
{visibilityToggleLabel}
111+
</HamburgerTrigger>
112+
</DxcTooltip>
111113
</VisibilityToggle>
112114
)}
113115
<BodyContainer>

0 commit comments

Comments
 (0)