Merge pull request #1636 from dxc-technology/rarrojolopez-footer

Remove deprecated `padding` prop from the Footer component

Author: GomezIvann

lib/src/footer/Footer.stories.tsx

@@ -91,78 +91,7 @@ const opinionatedTheme = {
     baseColor: "#000000",
     fontColor: "#ffffff",
     accentColor: "#0095ff",
-    logo: (
-      <svg id="g10" xmlns="http://www.w3.org/2000/svg" width="280.781" height="32" viewBox="0 0 280.781 32">
-        <g id="g12">
-          <path
-            id="path14"
-            d="M171.5-54.124v12.539h-3.6V-54.124h-4.973v-3.191h13.54v3.191H171.5"
-            transform="translate(-68.528 65.45)"
-            fill="#fff"
-          />
-          <path
-            id="path16"
-            d="M189.96-41.585V-57.315h12.326v3.079h-8.753v3.191h7.7v3.078h-7.7v3.3h8.87v3.078H189.96"
-            transform="translate(-77.56 65.45)"
-            fill="#fff"
-          />
-          <path
-            id="path18"
-            d="M223.558-41.438a8.1,8.1,0,0,1-8.382-8.1v-.045a8.161,8.161,0,0,1,8.522-8.146,8.6,8.6,0,0,1,6.444,2.431l-2.289,2.543a6.133,6.133,0,0,0-4.178-1.778,4.743,4.743,0,0,0-4.738,4.905v.045a4.752,4.752,0,0,0,4.738,4.95,6,6,0,0,0,4.295-1.845l2.288,2.228a8.491,8.491,0,0,1-6.7,2.813"
-            transform="translate(-86.019 65.583)"
-            fill="#fff"
-          />
-          <path
-            id="path20"
-            d="M254.988-41.585V-47.9h-6.63v6.315h-3.6V-57.315h3.6v6.225h6.63v-6.225h3.594v15.731h-3.594"
-            transform="translate(-95.903 65.45)"
-            fill="#fff"
-          />
-          <path
-            id="path22"
-            d="M285.991-41.585l-7.914-10v10h-3.549V-57.315h3.316l7.657,9.685v-9.685h3.549v15.731h-3.058"
-            transform="translate(-105.869 65.45)"
-            fill="#fff"
-          />
-          <path
-            id="path24"
-            d="M317.2-49.583a4.869,4.869,0,0,0-4.949-4.95,4.793,4.793,0,0,0-4.9,4.905v.045a4.869,4.869,0,0,0,4.949,4.95,4.793,4.793,0,0,0,4.9-4.905Zm-4.949,8.145c-5.043,0-8.661-3.623-8.661-8.1v-.045c0-4.478,3.666-8.146,8.708-8.146s8.66,3.623,8.66,8.1v.045c0,4.477-3.664,8.145-8.708,8.145"
-            transform="translate(-115.631 65.583)"
-            fill="#fff"
-          />
-          <path
-            id="path26"
-            d="M336.786-41.585V-57.315h3.6v12.584h8.148v3.146H336.786"
-            transform="translate(-126.654 65.45)"
-            fill="#fff"
-          />
-          <path
-            id="path28"
-            d="M372.78-49.583a4.87,4.87,0,0,0-4.949-4.95,4.794,4.794,0,0,0-4.9,4.905v.045a4.869,4.869,0,0,0,4.949,4.95,4.794,4.794,0,0,0,4.9-4.905Zm-4.949,8.145c-5.043,0-8.662-3.623-8.662-8.1v-.045c0-4.478,3.666-8.146,8.708-8.146s8.661,3.623,8.661,8.1v.045c0,4.477-3.666,8.145-8.708,8.145"
-            transform="translate(-135.016 65.583)"
-            fill="#fff"
-          />
-          <path
-            id="path30"
-            d="M399.735-41.438c-5.09,0-8.592-3.443-8.592-8.1v-.045a8.243,8.243,0,0,1,8.568-8.146,9.18,9.18,0,0,1,6.42,2.16l-2.265,2.634a6.141,6.141,0,0,0-4.272-1.6,4.807,4.807,0,0,0-4.692,4.905v.045a4.8,4.8,0,0,0,4.949,4.995,5.89,5.89,0,0,0,3.384-.945v-2.25h-3.618v-2.992h7.1v6.841a10.837,10.837,0,0,1-6.98,2.5"
-            transform="translate(-145.284 65.583)"
-            fill="#fff"
-          />
-          <path
-            id="path32"
-            d="M428.664-47.855v6.27h-3.6v-6.2l-6.28-9.528h4.2L426.89-51l3.968-6.315h4.085l-6.28,9.46"
-            transform="translate(-154.162 65.45)"
-            fill="#fff"
-          />
-          <path
-            id="path34"
-            d="M84.218-55.737a10.063,10.063,0,0,1,2.589-4.4,9.792,9.792,0,0,1,6.985-2.77h11.328V-69.3H93.792a17.041,17.041,0,0,0-11.8,4.759,16.344,16.344,0,0,0-3.547,5.115,13.247,13.247,0,0,0-1.122,3.688Zm0,4.877a10.065,10.065,0,0,0,2.589,4.4,9.793,9.793,0,0,0,6.985,2.77h11.328V-37.3H93.792a17.042,17.042,0,0,1-11.8-4.759,16.339,16.339,0,0,1-3.547-5.114,13.251,13.251,0,0,1-1.122-3.688ZM63.1-47.98,54.45-37.3H45.873l12.957-16-12.957-16H54.45L63.1-58.619l8.65-10.68h8.578l-12.957,16,12.957,16H71.749ZM48.875-55.737a13.212,13.212,0,0,0-1.122-3.688,16.359,16.359,0,0,0-3.546-5.115,17.043,17.043,0,0,0-11.8-4.759H21.08v6.393H32.408a9.79,9.79,0,0,1,6.985,2.77,10.072,10.072,0,0,1,2.59,4.4Zm0,4.877a13.215,13.215,0,0,1-1.122,3.688,16.353,16.353,0,0,1-3.546,5.114,17.044,17.044,0,0,1-11.8,4.759H21.08v-6.393H32.408a9.791,9.791,0,0,0,6.985-2.77,10.074,10.074,0,0,0,2.59-4.4h6.892"
-            transform="translate(-21.08 69.298)"
-            fill="#fff"
-          />
-        </g>
-      </svg>
-    ),
+    logo: "https://upload.wikimedia.org/wikipedia/commons/thumb/b/b8/2021_Facebook_icon.svg/2048px-2021_Facebook_icon.svg.png",
   },
 };
 
@@ -197,23 +126,6 @@ export const Chromatic = () => (
       <Title title="Xxlarge margin" theme="light" level={4} />
       <DxcFooter margin="xxlarge"></DxcFooter>
     </ExampleContainer>
-    <Title title="Padding" theme="light" level={2} />
-    <ExampleContainer>
-      <Title title="Xxsmall padding" theme="light" level={4} />
-      <DxcFooter padding="xxsmall"></DxcFooter>
-      <Title title="Xsmall padding" theme="light" level={4} />
-      <DxcFooter padding="xsmall"></DxcFooter>
-      <Title title="Small padding" theme="light" level={4} />
-      <DxcFooter padding="small"></DxcFooter>
-      <Title title="Medium padding" theme="light" level={4} />
-      <DxcFooter padding="medium"></DxcFooter>
-      <Title title="Large padding" theme="light" level={4} />
-      <DxcFooter padding="large"></DxcFooter>
-      <Title title="Xlarge padding" theme="light" level={4} />
-      <DxcFooter padding="xlarge"></DxcFooter>
-      <Title title="Xxlarge padding" theme="light" level={4} />
-      <DxcFooter padding="xxlarge"></DxcFooter>
-    </ExampleContainer>
     <Title title="Opinionated theme" theme="light" level={2} />
     <ExampleContainer>
       <HalstackProvider theme={opinionatedTheme}>

lib/src/footer/Footer.tsx

@@ -12,7 +12,6 @@ const DxcFooter = ({
   bottomLinks,
   copyright,
   children,
-  padding,
   margin,
   tabIndex = 0,
 }: FooterPropsType): JSX.Element => {
@@ -59,7 +58,7 @@ const DxcFooter = ({
           <SocialLinkContainer>{socialLink}</SocialLinkContainer>
         </FooterHeader>
         <div>
-          <ChildComponents padding={padding}>
+          <ChildComponents>
             <BackgroundColorProvider color={colorsTheme.footer.backgroundColor}>{children}</BackgroundColorProvider>
           </ChildComponents>
           <FooterFooter className="footerFooter">
@@ -137,17 +136,8 @@ const BottomLinks = styled.div`
   align-self: center;
 `;
 
-const ChildComponents = styled.div<{ padding: FooterPropsType["padding"] }>`
+const ChildComponents = styled.div`
   min-height: 16px;
-  padding: ${(props) => (props.padding && typeof props.padding !== "object" ? spaces[props.padding] : "0px")};
-  padding-top: ${(props) =>
-    props.padding && typeof props.padding === "object" && props.padding.top ? spaces[props.padding.top] : ""};
-  padding-right: ${(props) =>
-    props.padding && typeof props.padding === "object" && props.padding.right ? spaces[props.padding.right] : ""};
-  padding-bottom: ${(props) =>
-    props.padding && typeof props.padding === "object" && props.padding.bottom ? spaces[props.padding.bottom] : ""};
-  padding-left: ${(props) =>
-    props.padding && typeof props.padding === "object" && props.padding.left ? spaces[props.padding.left] : ""};
   overflow: hidden;
 `;
 

lib/src/footer/types.ts

@@ -57,12 +57,6 @@ type FooterPropsType = {
    * Size of the top margin to be applied to the footer.
    */
   margin?: Space | Size;
-  /**
-   * @deprecated This prop will be removed shortly, consider using the Inset component for this purpose.
-   * Size of the padding to be applied to the custom area of the component.
-   * You can pass an object with properties in order to specify different padding sizes.
-   */
-  padding?: Space | Size;
 };
 
 export default FooterPropsType;

website/screens/components/footer/code/FooterCodePage.tsx

@@ -1,125 +1,97 @@
 import {
-  DxcAlert,
   DxcFlex,
-  DxcLink,
   DxcTable,
 } from "@dxc-technology/halstack-react";
 import QuickNavContainer from "@/common/QuickNavContainer";
 import QuickNavContainerLayout from "@/common/QuickNavContainerLayout";
 import DocFooter from "@/common/DocFooter";
 import Code from "@/common/Code";
 import HeaderDescriptionCell from "@/common/HeaderDescriptionCell";
-import StatusTag from "@/common/StatusTag";
-import Link from "next/link";
 
 const sections = [
   {
     title: "Props",
     content: (
-      <>
-        <DxcAlert type="warning" size="fillParent">
-          The <Code>padding</Code> prop has been deprecated. Consider using
-          layout components like the{" "}
-          <Link href="/components/inset/" passHref>
-            <DxcLink>Inset</DxcLink>
-          </Link>{" "}
-          for the same purpose.
-        </DxcAlert>
-        <DxcTable>
-          <thead>
-            <tr>
-              <th>Name</th>
-              <th>Default</th>
-              <HeaderDescriptionCell>Description</HeaderDescriptionCell>
-            </tr>
-          </thead>
-          <tbody>
-            <tr>
-              <td>socialLinks: object[]</td>
-              <td>
-                <Code>[]</Code>
-              </td>
-              <td>
-                An array of objects representing the links that will be rendered
-                as icons at the top-right side of the footer. Each object has
-                the following properties:
-                <ul>
-                  <li>
-                    <b>logo</b>: Element or path used as the icon for the link.
-                  </li>
-                  <li>
-                    <b>href</b>: URL of the page the link goes to.
-                  </li>
-                </ul>
-              </td>
-            </tr>
-            <tr>
-              <td>bottomLinks: object[]</td>
-              <td>
-                <Code>[]</Code>
-              </td>
-              <td>
-                An array of objects representing the links that will be rendered
-                at the bottom part of the footer. Each object has the following
-                properties:
-                <ul>
-                  <li>
-                    <b>text</b>: Text for the link.
-                  </li>
-                  <li>
-                    <b>href</b>: URL of the page the link goes to.
-                  </li>
-                </ul>
-              </td>
-            </tr>
-            <tr>
-              <td>copyright: string</td>
-              <td></td>
-              <td>The text that will be displayed as copyright disclaimer.</td>
-            </tr>
-            <tr>
-              <td>children: node</td>
-              <td></td>
-              <td>
-                The center section of the footer. Can be used to render custom
-                content in this area.
-              </td>
-            </tr>
-            <tr>
-              <td>margin: string</td>
-              <td></td>
-              <td>
-                Size of the top margin to be applied to the footer ('xxsmall' |
-                'xsmall' | 'small' | 'medium' | 'large' | 'xlarge' | 'xxlarge').
-              </td>
-            </tr>
-            <tr>
-              <td>padding: string | object</td>
-              <td></td>
-              <td>
-                <DxcFlex gap="0.25rem" direction="column" alignItems="baseline">
-                  <StatusTag status="Deprecated">Deprecated</StatusTag>
-                  Size of the padding to be applied to the custom area of the
-                  component ('xxsmall' | 'xsmall' | 'small' | 'medium' | 'large'
-                  | 'xlarge' | 'xxlarge'). You can pass an object with 'top',
-                  'bottom', 'left' and 'right' properties in order to specify
-                  different padding sizes.
-                </DxcFlex>
-              </td>
-            </tr>
-            <tr>
-              <td>tabIndex: number</td>
-              <td>
-                <Code>0</Code>
-              </td>
-              <td>
-                Value of the tabindex for all interactuable elements, except
-                those inside the custom area.
-              </td>
-            </tr>
-          </tbody>
-        </DxcTable>
-      </>
+      <DxcTable>
+        <thead>
+          <tr>
+            <th>Name</th>
+            <th>Default</th>
+            <HeaderDescriptionCell>Description</HeaderDescriptionCell>
+          </tr>
+        </thead>
+        <tbody>
+          <tr>
+            <td>socialLinks: object[]</td>
+            <td>
+              <Code>[]</Code>
+            </td>
+            <td>
+              An array of objects representing the links that will be rendered
+              as icons at the top-right side of the footer. Each object has the
+              following properties:
+              <ul>
+                <li>
+                  <b>logo</b>: Element or path used as the icon for the link.
+                </li>
+                <li>
+                  <b>href</b>: URL of the page the link goes to.
+                </li>
+              </ul>
+            </td>
+          </tr>
+          <tr>
+            <td>bottomLinks: object[]</td>
+            <td>
+              <Code>[]</Code>
+            </td>
+            <td>
+              An array of objects representing the links that will be rendered
+              at the bottom part of the footer. Each object has the following
+              properties:
+              <ul>
+                <li>
+                  <b>text</b>: Text for the link.
+                </li>
+                <li>
+                  <b>href</b>: URL of the page the link goes to.
+                </li>
+              </ul>
+            </td>
+          </tr>
+          <tr>
+            <td>copyright: string</td>
+            <td></td>
+            <td>The text that will be displayed as copyright disclaimer.</td>
+          </tr>
+          <tr>
+            <td>children: node</td>
+            <td></td>
+            <td>
+              The center section of the footer. Can be used to render custom
+              content in this area.
+            </td>
+          </tr>
+          <tr>
+            <td>margin: string</td>
+            <td></td>
+            <td>
+              Size of the top margin to be applied to the footer ('xxsmall' |
+              'xsmall' | 'small' | 'medium' | 'large' | 'xlarge' | 'xxlarge').
+            </td>
+          </tr>
+          <tr>
+            <td>tabIndex: number</td>
+            <td>
+              <Code>0</Code>
+            </td>
+            <td>
+              Value of the tabindex for all interactuable elements, except those
+              inside the custom area.
+            </td>
+          </tr>
+        </tbody>
+      </DxcTable>
     ),
   },
   {