Skip to content

Commit 7f47f8f

Browse files
committed
Breadcrumbs updates based on feedback
1 parent 26f3851 commit 7f47f8f

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

lib/src/breadcrumbs/Breadcrumbs.stories.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,8 @@ const Breadcrumbs = () => (
178178
</ExampleContainer>
179179
</ExampleContainer>
180180
<Title title="Collapsed variant with dropdown menu opened" theme="light" level={3} />
181-
<ExampleContainer>
182-
<DxcContainer height="200px">
183-
<DxcBreadcrumbs items={items} />
184-
</DxcContainer>
181+
<ExampleContainer expanded>
182+
<DxcBreadcrumbs items={items} />
185183
</ExampleContainer>
186184
</>
187185
);

lib/src/breadcrumbs/Breadcrumbs.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,13 @@ describe("Breadcrumbs component tests", () => {
6969
<DxcBreadcrumbs
7070
onItemClick={onItemClick}
7171
items={[
72-
{ label: "Home", href: "/" },
73-
{ label: "Preferences", href: "/" },
72+
{ label: "Home", href: "/home" },
73+
{ label: "Preferences", href: "/preferences" },
7474
]}
7575
/>
7676
);
7777
userEvent.click(getByText("Home"));
78-
expect(onItemClick).toHaveBeenCalled();
78+
expect(onItemClick).toHaveBeenCalledWith("/home");
7979
});
8080
test("The onClick prop from an item is properly called (collapsed)", async () => {
8181
const onItemClick = jest.fn();
@@ -92,6 +92,6 @@ describe("Breadcrumbs component tests", () => {
9292
);
9393
await userEvent.click(getByRole("button"));
9494
await userEvent.click(getByText("Preferences"));
95-
expect(onItemClick).toHaveBeenCalled();
95+
expect(onItemClick).toHaveBeenCalledWith("/");
9696
});
9797
});

0 commit comments

Comments
 (0)