Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link in README from PR diff to repo code? #12

Open
iteles opened this issue Oct 19, 2018 · 1 comment
Open

Update link in README from PR diff to repo code? #12

iteles opened this issue Oct 19, 2018 · 1 comment
Labels
chore good first issue Good for newcomers question Further information is requested

Comments

@iteles
Copy link
Member

iteles commented Oct 19, 2018

Found through review of #11

Link currently points to https://github.com/dwyl/phoenix-ecto-append-only-log-example/pull/2/files#diff-db55bfd345510f8bbb29d36daadf7061R21, which at the time was part of a PR.

Should we now update this to https://github.com/dwyl/phoenix-ecto-append-only-log-example/blob/3eb130e103cef05ef57e5d1fcd2a54c7b723597d/priv/repo/migrations/20180912142549_create_addresses.exs ?

@iteles iteles added the question Further information is requested label Oct 19, 2018
@nelsonic
Copy link
Member

@iteles great question!
The line you are referring to is:
image
In the context of the PR it shows that the whole migration file was created as part of that PR
and the line in question was added as part of the migration.

I agree that in this context, simply linking to the file (and not the PR) will be "less confusing" to people reading it. (they won't be scratching their heads wondering why ...)

Something we can do in the next iteration. 👍

@nelsonic nelsonic added good first issue Good for newcomers chore labels Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants