Skip to content
This repository was archived by the owner on Oct 14, 2018. It is now read-only.

Commit 67f8c62

Browse files
committed
Clean up formatting to make memoizers more uniform
1 parent df8f383 commit 67f8c62

File tree

2 files changed

+20
-24
lines changed

2 files changed

+20
-24
lines changed

src/Cursor.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ import {makeSwapFromReact, makeValueFromReact, isReactCmp} from './ReactAdapter'
55

66
let debug = process.env.NODE_ENV !== 'production';
77

8+
89
let makeRefinedSwap = memoized(
910
(swapFn, paths) => refToHash(swapFn) + hashRecord(paths),
10-
(swapFn, paths) => (f) => swapFn(rootAt(paths, f))
11-
);
11+
(swapFn, paths) => (f) => swapFn(rootAt(paths, f)));
12+
1213

1314
class Cursor {
1415
constructor (value, swapFn) {
@@ -27,17 +28,14 @@ class Cursor {
2728
}
2829

2930

30-
let NewCursor_ = (value, swap) => new Cursor(value, swap);
31+
let NewCursor = memoized(
32+
(value, swap) => refToHash(swap) + hashRecord(value),
33+
(value, swap) => new Cursor(value, swap));
3134

32-
// reuse the same cursor instance for same {value swap},
33-
let hasher = (value, swap) => refToHash(swap) + hashRecord(value);
34-
let NewCursor = memoized(hasher, NewCursor_);
3535

36+
Cursor.build = (value, swap) => isReactCmp(value)
37+
? NewCursor(makeValueFromReact(value), makeSwapFromReact(value))
38+
: NewCursor(value, swap);
3639

37-
Cursor.build = (value, swap) => {
38-
return isReactCmp(value)
39-
? NewCursor(makeValueFromReact(value), makeSwapFromReact(value))
40-
: NewCursor(value, swap);
41-
};
4240

4341
export default Cursor;

src/RefCursor.js

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,16 @@ import {memoized, refToHash, hashRecord, getIn, rootAt} from './util';
22
import {merge, push, unshift, splice} from 'update-in';
33
import {makeDerefFromReact, makeSwapFromReact, isReactCmp} from './ReactAdapter';
44

5+
56
let makeRefinedSwap = memoized(
67
(swapFn, paths) => refToHash(swapFn) + hashRecord(paths),
7-
(swapFn, paths) => (f) => swapFn(rootAt(paths, f))
8-
);
8+
(swapFn, paths) => (f) => swapFn(rootAt(paths, f)));
9+
910

1011
let makeRefinedDeref = memoized(
1112
(deref, paths) => refToHash(deref) + hashRecord(paths),
12-
(deref, paths) => () => getIn(deref(), paths)
13-
);
13+
(deref, paths) => () => getIn(deref(), paths));
14+
1415

1516
class RefCursor {
1617
constructor (deref, swapFn) {
@@ -29,17 +30,14 @@ class RefCursor {
2930
}
3031

3132

32-
let NewRefCursor_ = (deref, swap) => new RefCursor(deref, swap);
33+
let NewRefCursor = memoized(
34+
(deref, swap) => refToHash(deref) + refToHash(swap),
35+
(deref, swap) => new RefCursor(deref, swap));
3336

34-
// reuse the same cursor instance for same {deref swap paths}
35-
let hasher = (deref, swap) => refToHash(deref) + refToHash(swap);
36-
let NewRefCursor = memoized(hasher, NewRefCursor_);
3737

38+
RefCursor.build = (deref, swap) => isReactCmp(deref)
39+
? NewRefCursor(makeDerefFromReact(deref), makeSwapFromReact(deref))
40+
: NewRefCursor(deref, swap);
3841

39-
RefCursor.build = (deref, swap) => {
40-
return isReactCmp(deref)
41-
? NewRefCursor(makeDerefFromReact(deref), makeSwapFromReact(deref))
42-
: NewRefCursor(deref, swap);
43-
};
4442

4543
export default RefCursor;

0 commit comments

Comments
 (0)