SPY-191: Don't force reconnect on E2BIG with binary protocol.

Motivation
----------
In the current codebase, a socket is forcefully reset when the server
returns an E2BIG response, that is when the document is larger than the
possible value size.

Modifications
-------------
While this needs to be done on the ASCII protocol, doing so is not needed
with binary protocol and can be considered a bug/leftover.

The code is modified so that E2BIG just translates into a non-success response
like any other error and the proper error code identifies the cause.

The test cases have been modified for binary to reflect the change.

Result
------
Do not force reconnect / treat the issue as a server error on the binary
protocol - the ASCII protocol is unaffected.

Change-Id: Idf392d146d30b2e96dc198a93a3cc6598dae3fc6
Reviewed-on: http://review.couchbase.org/61927
Reviewed-by: Simon Baslé <simon@couchbase.com>
Tested-by: Michael Nitschinger <michael.nitschinger@couchbase.com>
Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>

Author: daschl

src/main/java/net/spy/memcached/protocol/binary/OperationImpl.java

@@ -239,9 +239,9 @@ protected OperationStatus getStatusForErrorCode(int errCode, byte[] errPl)
             case ERR_NOT_STORED:
                 return new CASOperationStatus(false, new String(errPl),
                         CASResponse.NOT_FOUND, statusCode);
-            case ERR_2BIG:
             case ERR_INTERNAL:
                 handleError(OperationErrorType.SERVER, new String(errPl));
+            case ERR_2BIG:
             case ERR_INVAL:
             case ERR_DELTA_BADVAL:
             case ERR_NOT_MY_VBUCKET:

src/test/java/net/spy/memcached/BinaryClientTest.java

@@ -25,11 +25,15 @@
 
 import java.net.InetSocketAddress;
 import java.util.Map;
+import java.util.Random;
 import java.util.concurrent.ExecutionException;
 
 import net.spy.memcached.internal.GetFuture;
 import net.spy.memcached.internal.OperationFuture;
+import net.spy.memcached.ops.OperationErrorType;
+import net.spy.memcached.ops.OperationException;
 import net.spy.memcached.ops.StatusCode;
+import net.spy.memcached.transcoders.SerializingTranscoder;
 
 /**
  * This test assumes a binary server is running on the host specified int the
@@ -221,4 +225,22 @@ public void testAsyncDecrementWithDefault() throws Exception {
     assertEquals(6, (long) f.get());
   }
 
+  @Override
+  public void testStupidlyLargeSetAndSizeOverride() throws Exception {
+    Random r = new Random();
+    SerializingTranscoder st = new SerializingTranscoder(Integer.MAX_VALUE);
+
+    st.setCompressionThreshold(Integer.MAX_VALUE);
+
+    byte[] data = new byte[21 * 1024 * 1024];
+    r.nextBytes(data);
+
+    OperationFuture<Boolean> setResult = client.set("bigassthing", 60, data, st);
+    assertFalse(setResult.get());
+    assertEquals(StatusCode.ERR_2BIG, setResult.getStatus().getStatusCode());
+
+    client.set("k", 5, "Blah");
+    assertEquals("Blah", client.get("k"));
+  }
+
 }