SPY-168: isJSONObject should handle null or empty input values.

Motivation
----------
Before this change, the isJSONObject was suspect to NPEs and possibly also
regex match failings on empty strings, although that does not seem to be the
case on Java 1.7+.

Modifications
-------------
Specific null and empty checks have been added to make the method more robust.

Result
------
NPEs are not raised anymore and also empty strings are checked much quicker. Test
cases have been added to verify functionality.

Side note: An exception like this was reported on empty strings, but could not be
verified with Java 1.7 onward. It is suspected that this changeset also fixes
the issue given the input type and code process:

Original Exception: java.lang.StringIndexOutOfBoundsException: String index out of range: 0
Stack trace:
java.lang.String.charAt(String.java:658)
java.util.regex.Pattern$BmpCharProperty.match(Pattern.java:3715)
java.util.regex.Pattern$Ques.match(Pattern.java:4079)
java.util.regex.Pattern$Begin.match(Pattern.java:3472)
java.util.regex.Matcher.match(Matcher.java:1221)
java.util.regex.Matcher.matches(Matcher.java:559)
net.spy.memcached.util.StringUtils.isJsonObject(StringUtils.java:109)
net.spy.memcached.transcoders.SerializingTranscoder.encode(Seriali
...

Change-Id: Icaca2f3fef658cdb2c376b6b4dba12ae0327f240
Reviewed-on: http://review.couchbase.org/36695
Reviewed-by: Matt Ingenthron <matt@couchbase.com>
Reviewed-by: Michael Nitschinger <michael.nitschinger@couchbase.com>
Tested-by: Michael Nitschinger <michael.nitschinger@couchbase.com>

Author: daschl

src/main/java/net/spy/memcached/util/StringUtils.java

@@ -22,14 +22,14 @@
 
 package net.spy.memcached.util;
 
+import net.spy.memcached.KeyUtil;
+import net.spy.memcached.MemcachedClientIF;
+
 import java.util.Collection;
 import java.util.Iterator;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import net.spy.memcached.KeyUtil;
-import net.spy.memcached.MemcachedClientIF;
-
 /**
  * Utility methods on string objects.
  */
@@ -106,6 +106,10 @@ public static String join(final Collection<String> chunks,
    * @return true if it is a JSON object, false otherwise.
    */
   public static boolean isJsonObject(final String s) {
+    if (s == null || s.isEmpty()) {
+      return false;
+    }
+
     if (s.startsWith("{") || s.startsWith("[")
       || "true".equals(s) || "false".equals(s)
       || "null".equals(s) || decimalMatcher.reset(s).matches()) {

src/test/java/net/spy/memcached/util/StringUtilsTest.java

@@ -75,6 +75,15 @@ public void shouldValidateNonJSONObject() {
     assertFalse(StringUtils.isJsonObject("1,244.0"));
   }
 
+  @Test
+  public void shouldWorkWithEmptyOrNullStrings() {
+    assertFalse(StringUtils.isJsonObject(""));
+    assertFalse(StringUtils.isJsonObject(null));
+    assertFalse(StringUtils.isJsonObject("\r\n"));
+    assertFalse(StringUtils.isJsonObject("\n"));
+    assertFalse(StringUtils.isJsonObject(" "));
+  }
+
   @Test
   public void shouldValidateAsciiKey() {
     StringUtils.validateKey("mykey1234", false);