[Slack] Allow indexing private channels

[philipperolet]

Description

Context threads here and here

Private channels in which the Dust bot has been invited are now visible to sync by the admin, with warning.

Looks like this:

and this

Risk

The PR in itself is low risk (small code change + UX). The product risk is higher but has been discussed, see threads

Deploy Plan

• deploy front
• migration_31
• deploy connectors
• migration_32

[flvndvd]

🔥 Can we just make sure that the auto-join Slack channel does not automatically add private channels 🙏 ?

[philipperolet]

🔥 Can we just make sure that the auto-join Slack channel does not automatically add private channels 🙏 ?

Thanks for the check! not sure what you mean? Dust doesn't see private channels it has not been added to by a user of the channel. So it cannot add itself?

But I'd be glad if you could review the PR though 😉 🙏

[github-actions]

	Warnings
⚠️	Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against c2c1c76

[flvndvd]

🔥 Can we just make sure that the auto-join Slack channel does not automatically add private channels 🙏 ?

Thanks for the check! not sure what you mean? Dust doesn't see private channels it has not been added to by a user of the channel. So it cannot add itself?

But I'd be glad if you could review the PR though 😉 🙏

I meant that in connectors we automatically add Slack channels that match a pattern. We might want to ensure it does not add Private channels automatically. More context here:

dust/connectors/src/connectors/slack/auto_read_channel.ts

Line 32 in f89aba6

export async function autoReadChannel(

[philipperolet]

it can't add private channels this way because it doesn't see them 🙈

This auto add is for channels for which we receive a webhook notification via the "channels_created" webhook; which is unchanged by this PR so no risk there 👍

If the channel creator added the Dust bot when creating the channel, the channel would indeed be added but that's desired impossible

[fontanierh]

Should we say something like "You are synchronizing data from those private channels:"? I think it may be confusing for people if they pick a mix of private an non-private and only see confirmation for some channels.

Also, what if there are 30 private channels selected ? This modal would not really work right ?

[philipperolet]

Yep, I agree; technically, may not be only channels.
Will do from private source(s): ... and limit to 3 elements with ellipsis
@gabhubert PMRR, happy to change if need be