Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how we store group_ids on conversations and agent_configurations #8268

Open
flvndvd opened this issue Oct 28, 2024 · 2 comments
Open
Assignees

Comments

@flvndvd
Copy link
Contributor

flvndvd commented Oct 28, 2024

Today's group_ids on conversations and agent_configurations performs a conjunction on all group ids, this is too limiting as one space can have more than one group, we should perform disjunction between a space's groups.

To achieve this we need to update the way we store those to store a List of List of groupIds.

@Fraggle
Copy link
Contributor

Fraggle commented Oct 31, 2024

I don't understand the problem (and therefor, the solution).

@flvndvd
Copy link
Contributor Author

flvndvd commented Oct 31, 2024

The problem is that a space can have more than one group (we apply a disjunction/OR on the groups of a space). At the moment we only store a simple array of group ids on the agent_configurations and conversations on which we run a conjunction/AND. This does not work as a user is not expected to be in all space's group only one is enough.

We want to move towards a pattern that makes this easy to apply the same logic on agent_configurations and conversations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants