Skip to content

Conversation

@bynect
Copy link
Contributor

@bynect bynect commented Feb 26, 2025

fixing #1445

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.58%. Comparing base (80cc23d) to head (b73e2be).
⚠️ Report is 88 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
+ Coverage   65.57%   65.58%   +0.01%     
==========================================
  Files          50       50              
  Lines        8908     8911       +3     
  Branches     1042     1043       +1     
==========================================
+ Hits         5841     5844       +3     
  Misses       3067     3067              
Flag Coverage Δ
unittests 65.58% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bynect bynect changed the title Fix spec icon Fix dunstify icon and ids Mar 1, 2025
@bynect
Copy link
Contributor Author

bynect commented Mar 1, 2025

@liskin is it okay now?

@liskin
Copy link
Contributor

liskin commented Mar 3, 2025

@liskin is it okay now?

The get/set id code looks okay now. Thanks!

@bynect bynect merged commit 7f85725 into dunst-project:master Mar 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants