-
-
Notifications
You must be signed in to change notification settings - Fork 836
feat: add native Xdebug support #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinbrisa
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks!
Made a suggestion for Windows (again) as the startup command is slightly different
maxhelias
approved these changes
Aug 2, 2022
robinbrisa
reviewed
Aug 2, 2022
robinbrisa
approved these changes
Aug 2, 2022
…to feat/dev-image
7eba4f1
to
9ba567c
Compare
robinbrisa
suggested changes
Aug 3, 2022
robinbrisa
approved these changes
Aug 4, 2022
Great, thank you! |
Anthodev
added a commit
to Anthodev/symfony-docker
that referenced
this pull request
Sep 22, 2022
* Typo fix * Remove iconv workaround * Replace unsupported wip tld by localhost (dunglas#254) * ICU 71.1 support * feat: remove deprecated flags * feat: improve PHP config (dunglas#266) * feat: improve PHP config Tweak PHP config according to Blackfire's recommendation. * Update docker/php/conf.d/symfony.prod.ini Co-authored-by: Jacob Dreesen <jacob@hdreesen.de> * fix * fix Co-authored-by: Jacob Dreesen <jacob@hdreesen.de> * feat: Promote Compose v2 * Windows performance hint (dunglas#270) * docs: trust certificate on Windows (dunglas#272) Added information about how to add the caddy cert to the trusted certificates on Windows as this info was only provided for Linux & Mac. * feat: add native Xdebug support (dunglas#271) * feat: add native Xdebug support * cleanup * fix review * fix review * Improve docs * some more improvements * remove useless env var * Update README.md * Update README.md * refactor: improve image, uniformize with API Platform (dunglas#275) * refactor: improve image, uniformize with API Platform * feat: remove the SKELETON arg * chore: minor improvements and sync with API Platform (dunglas#277) * chore: compatibility with the new ORM recipe (dunglas#278) * chore: add a default value for XDEBUG_MODE * fix: stop use obsolete experimental_http3 option * Feat/supercharged symfony docker (#1) * 📦 NEW: Makefile + modified ci / dockerfile /README * 🐛 FIX: added a way to restore permission for the files * 🐛 FIX: Removed --no-deps option for php command in Docker through Makefile * 👌 IMPROVE: Added user permissions to manage file permissions * 🐛 FIX: remove an instruction in Dockerfile * 🐛 FIX: fixing permissions on small part of the Dockerfile Co-authored-by: Dezső BICZÓ <mxr576@users.noreply.github.com> Co-authored-by: Douglas Silva <doug.hs@protonmail.ch> Co-authored-by: Steven DUBOIS <git@duboiss.fr> Co-authored-by: Jérôme Zecca <jerome.zecca@cpiglobal.com> Co-authored-by: Stéphane P <n3wborn@protonmail.com> Co-authored-by: Kévin Dunglas <kevin@dunglas.fr> Co-authored-by: Jacob Dreesen <jacob@hdreesen.de> Co-authored-by: Maxime Hélias <maximehelias16@gmail.com> Co-authored-by: Robin Brisa <robin.brisa@gmail.com> Co-authored-by: Borislav Kosun <kosun.b@yandex.ua>
Anthodev
pushed a commit
to Anthodev/symfony-docker
that referenced
this pull request
Oct 4, 2022
* feat: add native Xdebug support * cleanup * fix review * fix review * Improve docs * some more improvements * remove useless env var
Anthodev
pushed a commit
to Anthodev/symfony-docker
that referenced
this pull request
Oct 4, 2022
* feat: add native Xdebug support * cleanup * fix review * fix review * Improve docs * some more improvements * remove useless env var
LucasHospice
pushed a commit
to LucasHospice/symfony-docker
that referenced
this pull request
Feb 21, 2024
* feat: add native Xdebug support * cleanup * fix review * fix review * Improve docs * some more improvements * remove useless env var
VitaliyMinenko
pushed a commit
to VitaliyMinenko/notofication-service
that referenced
this pull request
Sep 16, 2024
* feat: add native Xdebug support * cleanup * fix review * fix review * Improve docs * some more improvements * remove useless env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202.
Also simplifies the project.