Rework

Author: maxhelias

.dockerignore

@@ -23,7 +23,7 @@ bin/*
 !bin/console
 docker/db/data/
 helm/
+node_modules/
 public/bundles/
 var/
 vendor/
-node_modules/

README.md

@@ -29,10 +29,10 @@ A [Docker](https://www.docker.com/)-based installer and runtime for the [Symfony
 1. [Build options](docs/build.md)
 2. [Using Symfony Docker with an existing project](docs/existing-project.md)
 3. [Support for extra services](docs/extra-services.md)
-4. [Deploying in production](docs/production.md)
-5. [Installing Xdebug](docs/xdebug.md)
-6. [Using a Makefile](docs/makefile.md)
-7. [Building CSS and JS](docs/build-css-js.md)
+4. [Building CSS and JS](docs/build-css-js.md)
+5. [Deploying in production](docs/production.md)
+6. [Installing Xdebug](docs/xdebug.md)
+7. [Using a Makefile](docs/makefile.md)
 8. [Troubleshooting](docs/troubleshooting.md)
 
 ## Credits

docs/build-css-js.md

@@ -1,26 +1,38 @@
 # Building CSS and JS
 
-This example uses `npm` and [Webpack Encore](https://symfony.com/doc/current/frontend.html).
+For security reason and limit the size of the container, the default stack doesn't include any development "artifacts".
+To add it to the project and your development workflow follow this guide.
 
-Modify `Dockerfile` to build your assets before anything else.
+*This example uses `npm` and [Webpack Encore](https://symfony.com/doc/current/frontend.html).*
 
+Modify `Dockerfile` to build your assets :
+
+- At the top of the file before anything else
 ```diff
+ARG PHP_VERSION=8.1
 ARG CADDY_VERSION=2
-+ARG NODE_VERSION=17
-
++ARG NODE_VERSION=18
++
++# node "stage"
 +FROM node:${NODE_VERSION}-alpine AS symfony_node
++
 +WORKDIR /srv/app
++
 +COPY package*.json ./
++
 +RUN npm install
 +## If you are building your code for production
 +# RUN npm ci --only=production
++
++## You need to copy everything to use PostCSS, Tailwinds, ... 
 +COPY . .
++
 +RUN npm run build
 
 # "php" stage
 ```
 
-Then copy the built output in `public/build` (the configuration default) to the `php` container (which will then be copied later to `caddy`).
+- Then copy the built output in `public/build` (the configuration default) to the `php` container (which will then be copied later to `caddy`).
 
 ```diff
 VOLUME /srv/app/var
@@ -47,12 +59,12 @@ This will provide you with hot module reloading.
 +      context: .
 +      target: symfony_node
 +    volumes:
-+      - ./:/srv/app:rw,cached
++      - ./:/srv/app
 +    ports:
 +     - target: 8080
 +       published: 8080
 +       protocol: tcp
-+    command: 'sh -c "npm install; npm run dev-server -- --client-web-socket-url https://localhost:8080 --host 0.0.0.0"'
++    command: 'sh -c "npm install; npm run dev-server -- --server-type https --client-web-socket-url https://localhost:8080 --host 0.0.0.0"'
 ```
 
 If file changes are not picked up, refer to this page: