api Issue 836: Should clear URI query params when moving large URIs to POST

https://codereview.appspot.com/13437043/

Author: ngmiceli-g

google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java

@@ -96,7 +96,9 @@ public void intercept(HttpRequest request) throws IOException {
       request.getHeaders().set(HEADER, requestMethod);
       if (requestMethod.equals(HttpMethods.GET)) {
         // take the URI query part and put it into the HTTP body
-        request.setContent(new UrlEncodedContent(request.getUrl()));
+        request.setContent(new UrlEncodedContent(request.getUrl().clone()));
+        // remove query parameters from URI
+        request.getUrl().clear();
       } else if (request.getContent() == null) {
         // Google servers will fail to process a POST unless the Content-Length header is specified
         request.setContent(new EmptyContent());

google-api-client/src/test/java/com/google/api/client/googleapis/MethodOverrideTest.java

@@ -95,6 +95,7 @@ public void testInterceptMaxLength() throws IOException {
     new MethodOverride().intercept(request);
     assertEquals(HttpMethods.POST, request.getRequestMethod());
     assertEquals(HttpMethods.GET, request.getHeaders().get(MethodOverride.HEADER));
+    assertEquals(HttpTesting.SIMPLE_GENERIC_URL, request.getUrl());
     char[] arr2 = new char[arr.length + 2];
     Arrays.fill(arr2, 'x');
     arr2[0] = 'a';