Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Avoid struct-like enum variants? #368

Open
duesee opened this issue Oct 11, 2023 · 1 comment
Open

refactor: Avoid struct-like enum variants? #368

duesee opened this issue Oct 11, 2023 · 1 comment
Labels
breaking Breaking change enhancement New feature or request help wanted Extra attention is needed
Milestone
14. Release low- ...

Comments

@duesee
Copy link
Owner

duesee commented Oct 11, 2023

This would give us the flexibility to re-group variants, e.g., enum CommandAny, by sacrifycing only a little of readability.
@duesee duesee added enhancement New feature or request help wanted Extra attention is needed breaking Breaking change labels Oct 11, 2023
@duesee duesee mentioned this issue Jun 1, 2024
Closed
17 tasks
@duesee duesee self-assigned this Jun 26, 2024
@duesee
Copy link
Owner Author

duesee commented Jun 29, 2024 •
edited
Loading

I... 'm not too keen to do this right now. It adds quite a bit of boilerplate for theoretical usage. In fact, it's only really useful for Authenticate (due to our experience in imap-next.)

Maybe we should refactor CommandBody::Authenticate only for now?

@duesee duesee removed their assignment Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Breaking change enhancement New feature or request help wanted Extra attention is needed
Projects
imap-{types,codec}
Status: No status
Milestone
14. Release low- to high-level IMAP s...
Development

No branches or pull requests
1 participant
@duesee