(max - this.inFlight()) have to be greater than or equal to 0

[743v45]

const RRL = require('./lib/roundrobinlist');

const list = new RRL([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);

console.log(list.next(1));
// [ 1 ]
console.log(list.next(-2));
// [
//   2, 3, 4, 5,
//   6, 7, 8, 9
// ]

[dudleycarr]

Might be nice to put in a check for roundrobinlist. However, is there ever a chance that inFlight would be less than zero?

[743v45]

https://github.com/dudleycarr/nsqjs/blob/main/lib/readerrdy.js#L593

[dudleycarr]

Sure, but are you running into a situation where max - this.inFlight() < 0?

[743v45]

const RRL = require('./lib/roundrobinlist');
const list = new RRL([1, 2, 3]);
console.log(list.next(2));
// [ 1, 2 ]
console.log(list.next(2));
// [ 3 ]

roundrobinlist.next is incomplete actually.

[743v45]

Only when the perConnectionMax is 0, it will run here, but this code always rebalances within 50 milliseconds and cannot be observed.

[743v45]

When the current_state_name is TRY_ONE, max is 1 and inFlight() can be 3.

[dudleycarr]

OK, I'm convinced :) Let me investigate and work on a fix.