Skip to content

Conversation

@dus7
Copy link
Contributor

@dus7 dus7 commented Dec 1, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1206226850447395/task/1212236467731846?focus=true

Description

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

github-actions bot pushed a commit that referenced this pull request Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Generated file outputs:

Time updated: Mon, 01 Dec 2025 13:27:58 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/ios-config.json
  • v4/ios-config.json
--- v4/ios-config.json (and 1 other files)
+++ v4/ios-config.json
@@ -95481,8 +95481,11 @@
             "settings": {
                 "promptCooldownInterval": 24
             },
             "features": {
+                "experimentalBrowsingMenu": {
+                    "state": "internal"
+                },
                 "widgetReporting": {
                     "state": "disabled"
                 },
                 "inactivityNotification": {
latest
13 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

v5/ios-config.json
--- v5/ios-config.json
+++ v5/ios-config.json
@@ -95481,8 +95481,11 @@
             "settings": {
                 "promptCooldownInterval": 24
             },
             "features": {
+                "experimentalBrowsingMenu": {
+                    "state": "internal"
+                },
                 "widgetReporting": {
                     "state": "disabled"
                 },
                 "inactivityNotification": {

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

JSON approval analysis:

Time updated: Mon, 01 Dec 2025 13:38:04 GMT

legacy

❌ Manual Review Required

  • v3/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/experimentalBrowsingMenu (add)
  • v4/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/experimentalBrowsingMenu (add)
latest

❌ Manual Review Required

  • v5/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/experimentalBrowsingMenu (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant