Skip to content

Conversation

@alessandroboron
Copy link
Contributor

@alessandroboron alessandroboron commented Oct 15, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/414709148257752/task/1211645814224499?focus=true

Description

Reduce high disk writes / energy consumption due to frequent updates of malicious site protection hash prefix
Screenshot 2025-10-15 at 6 32 39 pm

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

Note

Updates maliciousSiteProtection hash prefix update frequency from 20 to 480 minutes in overrides/ios-override.json.

Written by Cursor Bugbot for commit 436b86a. This will update automatically on new commits. Configure here.

github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
@github-actions
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Generated file outputs:

Time updated: Wed, 15 Oct 2025 11:35:32 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/ios-config.json
  • v4/ios-config.json
--- v4/ios-config.json (and 1 other files)
+++ v4/ios-config.json
@@ -95171,9 +95171,9 @@
                     }
                 }
             },
             "settings": {
-                "hashPrefixUpdateFrequency": 20,
+                "hashPrefixUpdateFrequency": 480,
                 "filterSetUpdateFrequency": 720
             }
         },
         "marketplaceAdPostback": {
latest
13 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

v5/ios-config.json
--- v5/ios-config.json
+++ v5/ios-config.json
@@ -95171,9 +95171,9 @@
                     }
                 }
             },
             "settings": {
-                "hashPrefixUpdateFrequency": 20,
+                "hashPrefixUpdateFrequency": 480,
                 "filterSetUpdateFrequency": 720
             }
         },
         "marketplaceAdPostback": {

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

JSON approval analysis:

Time updated: Wed, 15 Oct 2025 11:35:41 GMT

legacy

❌ Manual Review Required

  • v3/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/maliciousSiteProtection/settings/hashPrefixUpdateFrequency (replace)
  • v4/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/maliciousSiteProtection/settings/hashPrefixUpdateFrequency (replace)
latest

❌ Manual Review Required

  • v5/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/maliciousSiteProtection/settings/hashPrefixUpdateFrequency (replace)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessandroboron alessandroboron added the DO NOT MERGE Don't merge this branch unless directed label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Don't merge this branch unless directed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants