adding impression pixels for duckplayer in landscape mode #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
afterxleep
approved these changes
Oct 29, 2024
ankushkushwaha
approved these changes
Oct 30, 2024
|
@shakyShane it seems the tests are failing here because of some required updates to the Mocks. I'll update them and get this merged. |
samsymons
added a commit
that referenced
this pull request
Oct 30, 2024
* main: adding impression pixels for duckplayer in landscape mode (#3493) Update autoconsent to v10.17.0 (#3504) Onboarding Add to Dock Tutorial (#3482) Blind attempt to fix Omnibar-related crash (#3500) Add to Dock Localised strings (#3494) Add to Dock Onboarding feature flag (#3476) Remove HomePageViewController code (#3454)
samsymons
added a commit
that referenced
this pull request
Nov 4, 2024
# By Daniel Bernal (6) and others # Via Daniel Bernal (3) and others * main: (21 commits) Validate VPN errors before re-throwing them (#3513) Allowing users to delete suggestions on macOS (#3465) Update build number Update build number Bump rexml from 3.3.8 to 3.3.9 (#3495) Release 7.142.1-1 (#3525) Add a debouncer to NavBars animator (#3519) Release 7.143.0-1 (#3516) Update to subscription cookie (#3512) Bug Fix: Phishing Detection Dataset Discrepancies (#3469) Duckplayer New Tab + Refactor (#3491) Blind attempt to fix Omnibar-related crash (#3514) Fix VPN server info metadata (#3501) Set version_check_wait_retry_limit to 1 (#3511) BSK changes for macOS release note screen update (#3466) Onboarding Add to Dock Promo view (#3505) Update BSK with autofill 15.1.0 (#3507) Update tests to use new tagline (#3439) adding impression pixels for duckplayer in landscape mode (#3493) Update autoconsent to v10.17.0 (#3504) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
shakyShane
added a commit
to duckduckgo/Android
that referenced
this pull request
Nov 4, 2024
Task/Issue URL: https://app.asana.com/0/0/1208637207606569/f ### Description The DuckPlayer frontend will send an event when the landscape view is shown, this PR adds a pixel for it. - Fire `duckplayer_landscape_layout_impressions` when the FE sends a telemetry event (https://app.asana.com/0/69071770703008/1208686513106880/f) - iOS PR: duckduckgo/iOS#3493 ### Steps to test this PR - ~install CSS at branch pr-releases/pr-1164~ - load DuckPlayer in landscape (or rotate) - you should receive 1 event per page-load, and the pixel should fire. ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)| --------- Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com> Co-authored-by: Cris Barreiro <cbarreiro@duckduckgo.com>
aitorvs
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Nov 6, 2024
Task/Issue URL: https://app.asana.com/0/0/1208637207606569/f ### Description The DuckPlayer frontend will send an event when the landscape view is shown, this PR adds a pixel for it. - Fire `duckplayer_landscape_layout_impressions` when the FE sends a telemetry event (https://app.asana.com/0/69071770703008/1208686513106880/f) - iOS PR: duckduckgo/iOS#3493 ### Steps to test this PR - ~install CSS at branch pr-releases/pr-1164~ - load DuckPlayer in landscape (or rotate) - you should receive 1 event per page-load, and the pixel should fire. ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)| --------- Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com> Co-authored-by: Cris Barreiro <cbarreiro@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201141132935289/1208637202774549/f
Tech Design URL:
CC:
Description:
the DuckPlayer frontend will start sending a generic 'telemetry' events soon - this PR adds support for the first one, but in a format that can be expanded later without needing new handlers.
Note
Please see https://deploy-preview-1164--content-scope-scripts.netlify.app/interfaces/duckplayer_messages.telemetryevent - there's only 1 event right now, but under
attributesit gives us scope to expand if needed.Steps to test this PR:
pr-releases/pr-1164Note: This change is backwards compatible with the existing application
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template