Skip to content

Conversation

@joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Nov 5, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211841662615810?focus=true

Description

  • Moves InputModeTabLayout to the browser-ui module

Steps to test this PR

  • Open the Input Screen
  • Verify that the Input Mode Widget renders correctly in light and dark mode

Copy link
Contributor Author

joshliebe commented Nov 5, 2025

@joshliebe joshliebe force-pushed the feature/josh/input-mode-common branch from 88a7a70 to e190c7a Compare November 5, 2025 00:46
@joshliebe joshliebe force-pushed the feature/josh/input-mode-common branch from 7d592b5 to 3455705 Compare November 5, 2025 16:08
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @joshliebe offline. We are going to move this to browser-ui instead of android-design-system. The main reason being, this is not an ADS Component but it’s something specific to Duck.ai.

@joshliebe joshliebe mentioned this pull request Nov 6, 2025
12 tasks
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving so you can move on

@joshliebe joshliebe force-pushed the feature/josh/input-mode-common branch from 3455705 to 7734047 Compare November 6, 2025 23:14
@joshliebe joshliebe changed the title Move InputModeTabLayout to common Move InputModeTabLayout to browser-ui Nov 7, 2025
@joshliebe joshliebe merged commit 90f0386 into develop Nov 7, 2025
10 of 11 checks passed
@joshliebe joshliebe deleted the feature/josh/input-mode-common branch November 7, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants