Configure script based on remote config

[CrisBarreiro]

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211755269770777?focus=true

Description

Configure script based on remote config

Steps to test this PR

Feature 1

• Apply patch
• Clean install app
• Wait for WebView to load and filter logcat by "Cris"
• Check there's a log with the script that has been injected, and it contains the following
  • const delay = 10;
  • const postInitialPing = true;
  • const replyToNativeMessages = true;

UI changes

n/a

[CrisBarreiro]

• Add native flags #7047
• Configure script based on remote config #7036 👈 (View in Graphite)
• Add base script for de-risking new WebViewCompat APIs #7034
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[CDRussell]

can we move all of this to its own class to keep BTF changes minimal and contained? thinking there would be a single line in BTF which calls through to your thing passing the WebView for instance.

[CrisBarreiro]

Sure. I wanted to avoid overengineering for this project, as we did for the previous one, but happy to reach a middle ground between overengineering and purely hacking our way around it

[CDRussell]

Approving, but think we should encapsulate that new code to a different class if we can

[CDRussell]

nit: i don't think this top level withContext(dispatchers.main()) helps with readability since you immediately jump to another dispatchers in the first of the nested block.

might read better to have val script = withContext(dispatchers.io()) where you get the script on IO, and then withContext(dispatchers.main() for calling addDocumentStartJavaScript. i.e., not nesting the withContext calls.

No strong feelings though.

[CrisBarreiro]

Merge activity

• Nov 4, 11:09 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Nov 4, 11:12 AM UTC: Graphite rebased this pull request as part of a merge.
• Nov 4, 11:36 AM UTC: @CrisBarreiro merged this pull request with Graphite.