PIR: Add database encryption #7010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
landomen
commented
Oct 28, 2025
| init { | ||
| logcat { "PIR-DB: Loading the sqlcipher native library" } | ||
| try { | ||
| LibraryLoader.loadLibrary(context, "sqlcipher") |
Contributor
Author
There was a problem hiding this comment.
If this method is called more than once with the same library name, the second and subsequent calls are ignored. (source)
It should be fine for both Autofill and PIR to call this multiple times
landomen
commented
Oct 28, 2025
karlenDimla
reviewed
Oct 29, 2025
pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/store/secure/PirSecureStorageKeyStore.kt
Show resolved
Hide resolved
karlenDimla
requested changes
Oct 29, 2025
Contributor
karlenDimla
left a comment
karlenDimla
left a comment
There was a problem hiding this comment.
See comments for more information.
landomen
force-pushed
the
feature/domen/pir-encrypted-db
branch
from
3f14418 to
247d4a4
Compare
karlenDimla
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211635200412099?focus=true
Description
Encrypts the PIR database.
Steps to test this PR
https://app.asana.com/1/137249556945/project/488551667048375/task/1211766506550756?focus=true
UI changes
No UI changes