PIR: Add support for Condition css action #6993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
karlenDimla
force-pushed
the
feature/karl/pir/condition-support
branch
from
86279d8 to
cc3b272
Compare
karlenDimla
force-pushed
the
feature/karl/pir/condition-support
branch
from
cc3b272 to
5586a4f
Compare
landomen
approved these changes
Nov 3, 2025
| @Provides | ||
| @SingleInstanceIn(AppScope::class) | ||
| @Named("pir") | ||
| fun providePirMoshi(moshi: Moshi): Moshi { |
Contributor
There was a problem hiding this comment.
Nice job moving this to a single place
Contributor
Author
There was a problem hiding this comment.
Yeah coz I had to change it in multiple places so might as well. 😅
Task/Issue URL: https://app.asana.com/1/137249556945/project/481882893211075/task/1211704453462470?focus=true ### Description See attached task description ### Steps to test this PR https://app.asana.com/1/137249556945/project/481882893211075/task/1211781203783161?focus=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1201462763415876/task/1210822764373104?focus=true
Description
See attached task descrtiption.
Steps to test this PR
Testing should be done on the stacked PRs.