Introduce DaxCta interface #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:duckduckgo/Android into feature/marcos/cta_helper # Conflicts: # app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaTest.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt
marcosholgado
changed the base branch from
feature/marcos/cta_new_interfaces
to
develop
subsymbolic
reviewed
Feb 3, 2020
cmonfortep
reviewed
Feb 3, 2020
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
A few comments, I may be missing some context and understanding of our CTAs, but hope they can help a bit. I didn't have time to test this tho. I will check again tomorrow.
app/src/androidTest/java/com/duckduckgo/app/cta/CtaDaxHelperTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/cta/CtaDaxHelperTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#679 has to be merged first
Task/Issue URL: https://app.asana.com/0/1125189844152671/1154748750174829 and https://app.asana.com/0/1125189844152671/1158928566141343
Tech Design URL:
CC:
Description:
Some of the code for each CTA was duplicated and it seemed the logic could be extracted to a different class. This PR introduces a new cta helper that does that job previously done on each CTA.
It also addresses an issue with the cta pixels sent so we don't send any days greater than 3.
Lastly it fixes an issue where the pixel for the bubble ctas were not being sent at the right time.
NOTE: Currently the PR tries to merge into
feature/marcos/cta_new_interfacesthe reason is because the branch is based on that one and to avoid having changes here that are part of a different PR. Once the other PR gets merged I'll change to point to develop.Steps to test this PR:
CTAs work as usual
meMax pixel day is 3
Change the method
AppInstallStore.daysInstalled()to always return 4.mem_odc_s with params: {cta=i:3}Send pixel asap and do not sent same pixel twice
mem_odc_s with params: {cta=i:1}and is sent as soon as the cta shows without having to wait.m_odc_sis not sent this time.Internal references:
Software Engineering Expectations
Technical Design Template