Move plugins to RefreshVersions #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
|
Needs to be updated and checked when #4971 gets merged. |
mikescamell
force-pushed
the
feature/mike/refreshversions-plugins
branch
2 times, most recently
from
56a0273 to
58df0e4
Compare
we're taking the opportunity to put the plugins in the plugin block (the new recommended way of declaring plugins) I had problems with AGP so left it of for now, we still use refreshVersions for it
now we have the anvil plugin in the versions.properties file we want to make sure that it, and the anvil dependencies stay on the same version so we fetch the anvil version declared in the version.properties file
we also ditch the version declaration in other gradle files as they are no longer needed
mikescamell
force-pushed
the
feature/mike/refreshversions-plugins
branch
from
58df0e4 to
4015f1e
Compare
mikescamell
added a commit
that referenced
this pull request
Sep 17, 2024
This reverts commit 5a70f8b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208315099637999/f
Description
Moves our plugins to refreshVersions so that they will be updated when the
refreshVersionstask is run.As part of this moved all but the AGP plugin to the plugins block. Not quite sure why that one didn’t want to work but don’t want to spend too much time on it, it’s still part of RefreshVersions.
I did not update the plugins as part of this PR.
Steps to test this PR
Feature 1
versions.propertiesmatch the previous versions./gradlew refreshVersionsand check the plugins get update comments (if they have an update of course)UI changes
N/A
Screenshot of the changes working