Sunsetting Github AoR #3263
Sunsetting Github AoR #3263
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
malmstein
force-pushed
the
06-20-Sunsetting_Github_AoR
branch
from
c7c3d18 to
e13f95f
Compare
CONTRIBUTING.md
Outdated
| @@ -30,9 +30,9 @@ After our team has investigated each issue, we will label them as: | |||
|
|
|||
| ## Contribute Code | |||
|
|
|||
| We welcome pull requests aimed at fixing bugs and security issues. | |||
| We welcome Pull Requests aimed at fixing bugs and security issues. Refactoring, product changes and other features won't be considered and therefore the Pull Request will be closed. | |||
There was a problem hiding this comment.
Posted a comment about this bit https://app.asana.com/0/0/1204558888185157/1204888958021886/f
|
@cmonfortep can you please review this with the latest changes? |
| @@ -24,7 +24,7 @@ import retrofit2.http.GET | |||
| @ContributesServiceApi(AppScope::class) | |||
| interface SurveyService { | |||
|
|
|||
| @GET("https://staticcdn.duckduckgo.com/survey/v2/survey-mobile.json") | |||
| @GET("https://ddg-sandbox.s3.amazonaws.com/survey/v2/survey-mobile.json") | |||
There was a problem hiding this comment.
Unrelated change. Seems a test endpoint for surveys.
There was a problem hiding this comment.
good catch, removing
| id: render_template | ||
| uses: chuhlomin/render-template@v1.7 | ||
| with: | ||
| template: .github/pr-reply-template.md |
There was a problem hiding this comment.
where is this file located .github/pr-reply-template.md?
There was a problem hiding this comment.
wrong name, updated
.github/issue-pr-template.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| Thank you for opening an Pull Request in our Repository. | |||
There was a problem hiding this comment.
This template is different from the one discussed in https://app.asana.com/0/1204853730139328/1204778116780347/f (is this the one that will be automatically posted when we receive a contribution?)
Feedback:
- "The issue has been forwarded..." -> That seems incorrect since we are in the PR template, probably copy & paste?
- "is the Pull Request is not" -> probably a typo? do you mean "if the Pull Request..."
- IMO, the whole part about contribution guidelines seems unnecessary and more related to the scenario of opening an issue, could we just use something similar to option 1 in https://app.asana.com/0/1204853730139328/1204778116780347/f
I don't have a strong choice here, so feel free to pick the one you prefer.
There was a problem hiding this comment.
I didn’t retroactively update the Asana task, it’s done now
Task/Issue URL: https://app.asana.com/0/1174433894299346/1204558888185157/f
Description
This PR adds the changes described in the task above.