fixes lint rule and suppress non di usages #2902
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
| @@ -40,6 +41,7 @@ import kotlinx.coroutines.ensureActive | |||
| import kotlinx.coroutines.flow.* | |||
| import kotlinx.coroutines.launch | |||
|
|
|||
| @SuppressLint("NoLifecycleObserver") // we don't use DI here | |||
There was a problem hiding this comment.
unsure if we prefer suppress or replace DefaultLifecycleObserver by MainProcessLifecycleObserver... I think better to suppress since we are not observing app lifecycle.
| @@ -30,6 +31,7 @@ import androidx.lifecycle.DefaultLifecycleObserver | |||
| import androidx.lifecycle.LifecycleOwner | |||
| import com.duckduckgo.mobile.android.ui.view.setAllParentsClip | |||
|
|
|||
| @SuppressLint("NoLifecycleObserver") // we don't use DI here | |||
There was a problem hiding this comment.
The comment is kinda wrong, the justification is not that we don't use DI. Is that we're not observing the app lifecycle.
Same for other comments
There was a problem hiding this comment.
true. I was thinking about that when writing my previous comment 👍
| @@ -66,6 +67,7 @@ import kotlinx.coroutines.isActive | |||
| import kotlinx.coroutines.launch | |||
| import timber.log.Timber | |||
|
|
|||
| @SuppressLint("NoLifecycleObserver") // we don't use DI here | |||
There was a problem hiding this comment.
I don't see where the SettingsViewModel observers the activity lifecycle. Maybe we need to fix that?
There was a problem hiding this comment.
mmm...you are right...not sure what's this doing here. I see onStop cancels deviceShieldStatePollingJob, which is always null. Gonna remove it, but please review it because probably related to AppTp old feature?
Task/Issue URL: https://app.asana.com/0/1202552961248957/1204091058652565/f
Description
Fixes lint rule.
Steps to test this PR
Feature 1
UI changes