Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve entering release notes into fastlane #1224

Merged
merged 4 commits into from
May 6, 2021

Conversation

CDRussell
Copy link
Member

Task/Issue URL: https://app.asana.com/0/488551667048375/1200292136839127/f
Tech Design URL:
CC:

Description:

Steps to test this PR:
ℹ️ Open Fastfile, and comment out line 145 (so it becomes #ensure_git_branch( branch: 'develop' ))

Test keeping existing release notes

  1. Run bundle exec fastlane release
  2. Verify you see the existing release notes
  3. Choose option 1 which is to "KEEP EXISTING" release notes
  4. Enter any version number (e.g., 0)
  5. Verify the release notes that are printed are the same as before
  6. 🛑 enter n to end this flow

Screen Shot 2021-05-06 at 12 15 44 PM

Test using custom release notes

  1. Run bundle exec fastlane release
  2. Choose option 2 which is to use "CUSTOM" release notes
  3. Verify you are prompted to enter custom release notes. Enter some (test multi-line release notes) and terminate the notes by entering END and pressing enter
  4. Enter any version number (e.g., 0)
  5. Verify the custom release notes you entered are displayed
  6. 🛑 enter n to end this flow

Test using standard release notes

  1. Run bundle exec fastlane release
  2. Choose option 3 which is to use standard bug fix release notes ("Bug fixes and other improvements")
  3. Enter any version number (e.g., 0)
  4. Verify the "Bug fixes and other improvements" release notes are displayed
  5. 🛑 enter n to end this flow

Internal references:

Software Engineering Expectations
Technical Design Template

@CDRussell CDRussell changed the title Feature/craig/fastlane release notes improve entering release notes into fastlane May 6, 2021
@CDRussell CDRussell requested a review from joshliebe May 6, 2021 11:21
Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gold! Thanks @CDRussell for championing this!

Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice upgrade, good job 👍

@CDRussell CDRussell merged commit 5df5fc8 into develop May 6, 2021
@CDRussell CDRussell deleted the feature/craig/fastlane_release_notes branch May 6, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants