Skip to content

Commit d5f78ae

Browse files
committed
Don't throw an exception but use the top as a default value
1 parent 468dafb commit d5f78ae

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

app/src/main/java/com/duckduckgo/app/appearance/AppearanceActivity.kt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,8 @@ class AppearanceActivity : DuckDuckGoActivity() {
200200
val subtitle =
201201
getString(
202202
when (omnibarType) {
203-
OmnibarType.SINGLE_TOP -> R.string.settingsAddressBarPositionTop
203+
OmnibarType.SPLIT, OmnibarType.SINGLE_TOP -> R.string.settingsAddressBarPositionTop
204204
OmnibarType.SINGLE_BOTTOM -> R.string.settingsAddressBarPositionBottom
205-
OmnibarType.SPLIT -> throw IllegalStateException("Split omnibar not supported in the position selection settings")
206205
},
207206
)
208207
binding.addressBarPositionSetting.setSecondaryText(subtitle)
@@ -239,9 +238,9 @@ class AppearanceActivity : DuckDuckGoActivity() {
239238
override fun onPositiveButtonClicked(selectedItem: Int) {
240239
val selectedTheme =
241240
when (selectedItem) {
242-
2 -> DuckDuckGoTheme.LIGHT
243-
3 -> DuckDuckGoTheme.DARK
244-
else -> DuckDuckGoTheme.SYSTEM_DEFAULT
241+
2 -> LIGHT
242+
3 -> DARK
243+
else -> SYSTEM_DEFAULT
245244
}
246245
viewModel.onThemeSelected(selectedTheme)
247246
}

0 commit comments

Comments
 (0)