-
Notifications
You must be signed in to change notification settings - Fork 928
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add loading bar performance experiment (#4978)
Task/Issue URL: https://app.asana.com/0/488551667048375/1208210291365732/f ### Description - Adds a custom experiment to measure the perceived performance of the loading bar on existing users. - The experiment randomly assigns a variant on-update, with percentage roll-out controlled by the loadingBarExp feature toggle. ### Steps to test this PR _Point at the config linked in the task_ ------- _In `LoadingBarExperimentVariantInitializer` set `val probabilities = doubleArrayOf(0.0, 1.0)`_ _Enrolment_ - [x] Fresh install from this branch - [x] Verify that `m_loading_bar_exp_enrollment_test` is sent _Daily_ - [x] Verify that `m_browser_feature_daily_active_user_d` is sent with param `loading_bar_exp=1` _URI loaded_ - [x] Load a site (eg. example.com) - [x] Verify that `m_uri_loaded` is sent with param `loading_bar_exp=1` _Pull to refresh_ - [x] Pull to refresh the page - [x] Verify that `m_browser_pull_to_refresh` is sent with param `loading_bar_exp=1` _Refresh_ - [x] Refresh the page from the menu - [x] Verify that `m_nav_r_p` is sent with param `loading_bar_exp=1` _Refresh action daily_ - [x] Verify that only one `m_refresh_action_daily` is sent with param `loading_bar_exp=1` _Loading bar_ - [x] Search for something on SERP - [x] Scroll to hide the loading bar - [x] Click a link - [x] Verify that the loading bar shows immediately _Feedback_ - [x] Go to “Settings” > “About” > “Share Feedback" - [x] Share positive feedback - [x] Verify that `mfbs_positive_submit` is sent with param `loading_bar_exp=1` - [x] Share negative feedback - [x] Verify that `mfbs_negative_submit` is sent with param `loading_bar_exp=1` ------- _In `LoadingBarExperimentVariantInitializer` set `val probabilities = doubleArrayOf(1.0, 0.0)`_ _Enrolment_ - [x] Fresh install from this branch - [x] Verify that `m_loading_bar_exp_enrollment_control` is sent _Daily_ - [x] Verify that `m_browser_feature_daily_active_user_d` is sent with param `loading_bar_exp=0` _URI loaded_ - [x] Load a site (eg. example.com) - [x] Verify that `m_uri_loaded` is sent with param `loading_bar_exp=0` _Pull to refresh_ - [x] Pull to refresh the page - [x] Verify that `m_browser_pull_to_refresh` is sent with param `loading_bar_exp=0` _Refresh_ - [x] Refresh the page from the menu - [x] Verify that `m_nav_r_p` is sent with param `loading_bar_exp=0` _Refresh action daily_ - [x] Verify that only one `m_refresh_action_daily` is sent with param `loading_bar_exp=0` _Loading bar_ - [x] Search for something on SERP - [x] Scroll to hide the loading bar - [x] Click a link - [x] Verify that there is a delay when showing the loading bar _Feedback_ - [x] Go to “Settings” > “About” > “Share Feedback" - [x] Share positive feedback - [x] Verify that `mfbs_positive_submit` is sent with param `loading_bar_exp=0` - [x] Share negative feedback - [x] Verify that `mfbs_negative_submit` is sent with param `loading_bar_exp=0` ------- _In the config, disable `allocateVariants`_ _Enrolment_ - [x] Fresh install from this branch - [x] Verify that `m_loading_bar_exp_enrollment` pixel is **not** sent _Daily_ - [x] Verify that `m_browser_feature_daily_active_user_d` is sent **without** param `loading_bar_exp` _URI loaded_ - [x] Load a site (eg. example.com) - [x] Verify that `m_uri_loaded` is sent **without** param `loading_bar_exp` _Pull to refresh_ - [x] Pull to refresh the page - [x] Verify that `m_browser_pull_to_refresh` is sent **without** param `loading_bar_exp` _Refresh_ - [x] Refresh the page from the menu - [x] Verify that `m_nav_r_p` is sent **without** param `loading_bar_exp` _Refresh action daily_ - [x] Verify that only one `m_refresh_action_daily` is sent **without** param `loading_bar_exp` _Feedback_ - [x] Go to “Settings” > “About” > “Share Feedback" - [x] Share positive feedback - [x] Verify that `mfbs_positive_submit` is sent *without* param `loading_bar_exp` - [x] Share negative feedback - [x] Verify that `mfbs_negative_submit` is sent *without* param `loading_bar_exp` ------- _In the config, re-enable `allocateVariants`_ - [x] Fresh install from this branch - [x] Load a site (eg. example.com) - [x] Verify that `m_uri_loaded` is sent with param `loading_bar_exp=0` _In the config, disable the `loadingBarExp` feature_ - [x] Reload the config - [x] Load a site (eg. example.com) - [x] Verify that `m_uri_loaded` is sent **without** param `loading_bar_exp` ### UI changes (Before/After) https://github.com/user-attachments/assets/3ec616ed-4006-435c-86fd-fa55db2f1271
- Loading branch information
Showing
24 changed files
with
853 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.