Throw an exception if split omnibar selected for SingleOmnibarLayout

0nko · 0nko · commit a8637548088b · 2025-10-28T17:51:45.000+01:00
diff --git a/app/src/main/java/com/duckduckgo/app/browser/omnibar/Omnibar.kt b/app/src/main/java/com/duckduckgo/app/browser/omnibar/Omnibar.kt
@@ -165,7 +165,7 @@ class Omnibar(
         binding.rootView.removeView(binding.omnibarLayoutBottom)
 
         return when (omnibarType) {
-            OmnibarType.SINGLE_TOP, OmnibarType.SPLIT -> {
+            OmnibarType.SINGLE_TOP -> {
                 binding.rootView.removeView(binding.singleOmnibarLayoutBottom)
                 binding.singleOmnibarLayoutTop
             }
@@ -175,6 +175,7 @@ class Omnibar(
                 adjustCoordinatorLayoutBehaviorForBottomOmnibar()
                 binding.singleOmnibarLayoutBottom
             }
+            else -> throw IllegalStateException("Invalid omnibar type for single omnibar setup: $omnibarType")
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ class Omnibar(`
`165`	`165`	`binding.rootView.removeView(binding.omnibarLayoutBottom)`
`166`	`166`
`167`	`167`	`return when (omnibarType) {`
`168`		`- OmnibarType.SINGLE_TOP, OmnibarType.SPLIT -> {`
	`168`	`+ OmnibarType.SINGLE_TOP -> {`
`169`	`169`	`binding.rootView.removeView(binding.singleOmnibarLayoutBottom)`
`170`	`170`	`binding.singleOmnibarLayoutTop`
`171`	`171`	`}`
`@@ -175,6 +175,7 @@ class Omnibar(`
`175`	`175`	`adjustCoordinatorLayoutBehaviorForBottomOmnibar()`
`176`	`176`	`binding.singleOmnibarLayoutBottom`
`177`	`177`	`}`
	`178`	`+ else -> throw IllegalStateException("Invalid omnibar type for single omnibar setup: $omnibarType")`
`178`	`179`	`}`
`179`	`180`	`}`
`180`	`181`