Skip to content

Commit 47cee2e

Browse files
malmsteinmalmstein
committed
baselines updated
1 parent 4f8a1e0 commit 47cee2e

File tree

13 files changed

+2250
-2876
lines changed

13 files changed

+2250
-2876
lines changed

‎android-design-system/design-system-internal/lint-baseline.xml‎

Lines changed: 958 additions & 23 deletions
Large diffs are not rendered by default.

‎android-design-system/design-system/lint-baseline.xml‎

Lines changed: 920 additions & 2625 deletions
Large diffs are not rendered by default.

‎app-tracking-protection/vpn-impl/lint-baseline.xml‎

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
id="BadPeriodicWorkRequestEnqueue"
2828
message="Use `enqueueUniquePeriodicWork()` instead of `enqueue()`">
2929
<location
30-
file="$GRADLE_USER_HOME/caches/8.10.2/transforms/c4bcc726a76f1dad06c79219aea4c14c/transformed/work-runtime-2.9.1/jars/classes.jar!/androidx/work/WorkManager.class"/>
30+
file="$GRADLE_USER_HOME/caches/8.10.2/transforms/2a4e339704b1b0d41939a899d56b03a7/transformed/work-runtime-2.9.1/jars/classes.jar!/androidx/work/WorkManager.class"/>
3131
</issue>
3232

3333
<issue
@@ -162,28 +162,6 @@
162162
column="58"/>
163163
</issue>
164164

165-
<issue
166-
id="QueryPermissionsNeeded"
167-
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
168-
errorLine1=" installedApps = packageManager.getInstalledApplications(PackageManager.GET_META_DATA)"
169-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
170-
<location
171-
file="src/main/java/com/duckduckgo/mobile/android/vpn/apps/TrackingProtectionAppsRepository.kt"
172-
line="116"
173-
column="40"/>
174-
</issue>
175-
176-
<issue
177-
id="QueryPermissionsNeeded"
178-
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
179-
errorLine1=" return@withContext packageManager.getInstalledApplications(PackageManager.GET_META_DATA)"
180-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
181-
<location
182-
file="src/main/java/com/duckduckgo/mobile/android/vpn/apps/TrackingProtectionAppsRepository.kt"
183-
line="124"
184-
column="43"/>
185-
</issue>
186-
187165
<issue
188166
id="VisibleForTests"
189167
message="This method should only be accessed from tests or within private scope"

‎app-tracking-protection/vpn-internal/lint-baseline.xml‎

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<issues format="6" by="lint 8.7.3" type="baseline" client="gradle" dependencies="false" name="AGP (8.7.3)" variant="all" version="8.7.3">
2+
<issues format="6" by="lint 8.8.2" type="baseline" client="gradle" dependencies="false" name="AGP (8.7.3)" variant="all" version="8.8.2">
33

44
<issue
55
id="DenyListedApi"
@@ -34,26 +34,4 @@
3434
column="17"/>
3535
</issue>
3636

37-
<issue
38-
id="QueryPermissionsNeeded"
39-
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
40-
errorLine1=" return packageManager.getInstalledApplications(PackageManager.GET_META_DATA)"
41-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
42-
<location
43-
file="src/main/java/com/duckduckgo/vpn/internal/feature/rules/ExceptionRulesDebugActivity.kt"
44-
line="116"
45-
column="31"/>
46-
</issue>
47-
48-
<issue
49-
id="QueryPermissionsNeeded"
50-
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
51-
errorLine1=" installedApps = packageManager.getInstalledApplications(PackageManager.GET_META_DATA)"
52-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
53-
<location
54-
file="src/main/java/com/duckduckgo/vpn/internal/feature/VpnInternalSettingsActivity.kt"
55-
line="167"
56-
column="40"/>
57-
</issue>
58-
5937
</issues>

‎app/lint-baseline.xml‎

Lines changed: 117 additions & 84 deletions
Large diffs are not rendered by default.

‎app/src/main/java/com/duckduckgo/app/global/shortcut/AppShortcutCreator.kt‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ import kotlinx.coroutines.launch
5151
import logcat.LogPriority.INFO
5252
import logcat.logcat
5353
import javax.inject.Inject
54+
import com.duckduckgo.mobile.android.R as CommonR
5455

5556
@Module
5657
@ContributesTo(AppScope::class)
@@ -165,8 +166,8 @@ class AppShortcutCreator @Inject constructor(
165166
.addNextIntent(adsActivity)
166167

167168
return ShortcutInfoCompat.Builder(context, SHORTCUT_ID_DESIGN_SYSTEM_DEMO)
168-
.setShortLabel(context.getString(R.string.ads_demo_activity_title))
169-
.setIcon(IconCompat.createWithResource(context, R.drawable.ic_dax_icon))
169+
.setShortLabel(context.getString(CommonR.string.ads_demo_activity_title))
170+
.setIcon(IconCompat.createWithResource(context, CommonR.drawable.ic_dax_icon))
170171
.setIntents(stackBuilder.intents)
171172
.build().toShortcutInfo()
172173
}

‎autofill/autofill-impl/lint-baseline.xml‎

Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2327,6 +2327,17 @@
23272327
column="54"/>
23282328
</issue>
23292329

2330+
<issue
2331+
id="Typos"
2332+
message="&quot;internett&quot; is usually capitalized as &quot;Internett&quot;"
2333+
errorLine1=" &lt;string name=&quot;importBookmarksErrorGenericMessageSecondary&quot;>Sørg for at du er koblet til internett og prøv igjen.&lt;/string>"
2334+
errorLine2=" ^">
2335+
<location
2336+
file="src/main/res/values-nb/strings-autofill-impl.xml"
2337+
line="313"
2338+
column="93"/>
2339+
</issue>
2340+
23302341
<issue
23312342
id="Untranslatable"
23322343
message="The resource string &quot;autofillManagementSurveyPromptTitle&quot; is marked as translatable=&quot;false&quot;, but is translated to &quot;bg&quot; (Bulgarian) here"
@@ -4450,6 +4461,83 @@
44504461
column="204"/>
44514462
</issue>
44524463

4464+
<issue
4465+
id="TypographyEllipsis"
4466+
message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
4467+
errorLine1=" &lt;string name=&quot;importBookmarksFromGooglePreImportDialogSelectFileButton&quot;>Избери файл с отметки...&lt;/string>"
4468+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
4469+
<location
4470+
file="src/main/res/values-bg/strings-autofill-impl.xml"
4471+
line="298"
4472+
column="77"/>
4473+
</issue>
4474+
4475+
<issue
4476+
id="TypographyEllipsis"
4477+
message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
4478+
errorLine1=" &lt;string name=&quot;importBookmarksFromGooglePreImportDialogSelectFileButton&quot;>Επιλογή αρχείου σελιδοδεικτών...&lt;/string>"
4479+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
4480+
<location
4481+
file="src/main/res/values-el/strings-autofill-impl.xml"
4482+
line="298"
4483+
column="77"/>
4484+
</issue>
4485+
4486+
<issue
4487+
id="TypographyEllipsis"
4488+
message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
4489+
errorLine1=" &lt;string name=&quot;importBookmarksFromGooglePreImportDialogSelectFileButton&quot;>Vali järjehoidjate fail...&lt;/string>"
4490+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
4491+
<location
4492+
file="src/main/res/values-et/strings-autofill-impl.xml"
4493+
line="298"
4494+
column="77"/>
4495+
</issue>
4496+
4497+
<issue
4498+
id="TypographyEllipsis"
4499+
message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
4500+
errorLine1=" &lt;string name=&quot;importBookmarksFromGooglePreImportDialogSelectFileButton&quot;>Seleziona il file dei segnalibri...&lt;/string>"
4501+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
4502+
<location
4503+
file="src/main/res/values-it/strings-autofill-impl.xml"
4504+
line="298"
4505+
column="77"/>
4506+
</issue>
4507+
4508+
<issue
4509+
id="TypographyEllipsis"
4510+
message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
4511+
errorLine1=" &lt;string name=&quot;importBookmarksFromGooglePreImportDialogSelectFileButton&quot;>Bladwijzerbestand selecteren...&lt;/string>"
4512+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
4513+
<location
4514+
file="src/main/res/values-nl/strings-autofill-impl.xml"
4515+
line="298"
4516+
column="77"/>
4517+
</issue>
4518+
4519+
<issue
4520+
id="TypographyEllipsis"
4521+
message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
4522+
errorLine1=" &lt;string name=&quot;importBookmarksProgressTitle&quot;>Importazione da Google...&lt;/string>"
4523+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
4524+
<location
4525+
file="src/main/res/values-it/strings-autofill-impl.xml"
4526+
line="300"
4527+
column="49"/>
4528+
</issue>
4529+
4530+
<issue
4531+
id="TypographyEllipsis"
4532+
message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
4533+
errorLine1=" &lt;string name=&quot;importBookmarksFromGooglePreImportDialogSelectFileButton&quot;>Selectează fișierul cu marcaje...&lt;/string>"
4534+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
4535+
<location
4536+
file="src/main/res/values-ro/strings-autofill-impl.xml"
4537+
line="304"
4538+
column="77"/>
4539+
</issue>
4540+
44534541
<issue
44544542
id="AlwaysShowAction"
44554543
message="Prefer &quot;`ifRoom`&quot; instead of &quot;`always`&quot;"

‎common/common-utils/lint-baseline.xml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,17 @@
5656
column="38"/>
5757
</issue>
5858

59+
<issue
60+
id="QueryPermissionsNeeded"
61+
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
62+
errorLine1=" this.getInstalledApplications(PackageManager.GET_META_DATA)"
63+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
64+
<location
65+
file="src/main/java/com/duckduckgo/common/utils/extensions/PackageManagerExtension.kt"
66+
line="34"
67+
column="14"/>
68+
</issue>
69+
5970
<issue
6071
id="QueryPermissionsNeeded"
6172
message="Consider adding a `&lt;queries>` declaration to your manifest when calling this method; see https://g.co/dev/packagevisibility for details"

‎duckchat/duckchat-impl/lint-baseline.xml‎

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,17 @@
7878
column="25"/>
7979
</issue>
8080

81+
<issue
82+
id="VectorPath"
83+
message="Very long vector path (1489 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
84+
errorLine1=" android:pathData=&quot;M17.5,13C19.985,13 22,15.015 22,17.5C22,19.985 19.985,22 17.5,22C15.015,22 13,19.985 13,17.5C13,15.015 15.015,13 17.5,13ZM15.481,3C15.135,3.611 14.549,4.066 13.848,4.242L13.547,4.317C13.371,4.361 13.211,4.423 13.066,4.5H7C5.067,4.5 3.5,6.067 3.5,8V16C3.5,16.225 3.521,16.444 3.562,16.657L7.94,12.28C8.233,11.987 8.708,11.987 9,12.28L11.532,14.811L15.833,10.51C15.962,10.978 16.222,11.333 16.549,11.575C13.872,12.001 11.785,14.198 11.527,16.927L8.47,13.87L4.218,18.123C4.857,18.96 5.865,19.5 7,19.5H11.842C11.868,19.574 11.896,19.647 11.925,19.72C12.151,20.288 11.774,21 11.163,21H7C4.239,21 2,18.761 2,16V8C2,5.239 4.239,3 7,3H15.481ZM15.25,16.75C14.974,16.75 14.75,16.974 14.75,17.25V17.75C14.75,18.026 14.974,18.25 15.25,18.25H19.75C20.026,18.25 20.25,18.026 20.25,17.75V17.25C20.25,16.974 20.026,16.75 19.75,16.75H15.25ZM22,11.584C22,12.263 21.087,12.643 20.5,12.303V8.887C20.818,8.588 21.212,8.368 21.652,8.259L21.953,8.183C21.969,8.179 21.985,8.174 22,8.17V11.584ZM17.272,2.41C17.397,1.913 18.103,1.913 18.228,2.41L18.303,2.712C18.67,4.182 19.818,5.329 21.288,5.697L21.59,5.772C22.087,5.897 22.087,6.603 21.59,6.728L21.288,6.803C19.818,7.17 18.67,8.318 18.303,9.788L18.228,10.09C18.103,10.587 17.397,10.587 17.272,10.09L17.197,9.788C16.83,8.318 15.682,7.17 14.212,6.803L13.91,6.728C13.413,6.603 13.413,5.897 13.91,5.772L14.212,5.697C15.682,5.329 16.83,4.182 17.197,2.712L17.272,2.41ZM8.5,7C9.328,7 10,7.672 10,8.5C10,9.328 9.328,10 8.5,10C7.672,10 7,9.328 7,8.5C7,7.672 7.672,7 8.5,7Z&quot;"
85+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
86+
<location
87+
file="src/main/res/drawable/ic_image_ai_hide_24.xml"
88+
line="25"
89+
column="27"/>
90+
</issue>
91+
8192
<issue
8293
id="VectorPath"
8394
message="Very long vector path (1021 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
@@ -210,14 +221,25 @@
210221
column="22"/>
211222
</issue>
212223

224+
<issue
225+
id="ContentDescription"
226+
message="Missing `contentDescription` attribute on image"
227+
errorLine1=" &lt;ImageView"
228+
errorLine2=" ~~~~~~~~~">
229+
<location
230+
file="src/main/res/layout/bottom_sheet_new_address_bar_option.xml"
231+
line="65"
232+
column="26"/>
233+
</issue>
234+
213235
<issue
214236
id="ContentDescription"
215237
message="Missing `contentDescription` attribute on image"
216238
errorLine1=" &lt;ImageView"
217239
errorLine2=" ~~~~~~~~~">
218240
<location
219241
file="src/main/res/layout/bottom_sheet_new_address_bar_option.xml"
220-
line="71"
242+
line="78"
221243
column="30"/>
222244
</issue>
223245

‎network-protection/network-protection-impl/lint-baseline.xml‎

Lines changed: 13 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
errorLine2=" ^">
9797
<location
9898
file="src/main/java/com/duckduckgo/networkprotection/impl/exclusion/systemapps/SystemAppsExclusionRepository.kt"
99-
line="81"
99+
line="84"
100100
column="9"/>
101101
</issue>
102102

@@ -107,7 +107,7 @@
107107
errorLine2=" ^">
108108
<location
109109
file="src/main/java/com/duckduckgo/networkprotection/impl/exclusion/systemapps/SystemAppsExclusionRepository.kt"
110-
line="90"
110+
line="93"
111111
column="9"/>
112112
</issue>
113113

@@ -155,50 +155,6 @@
155155
column="9"/>
156156
</issue>
157157

158-
<issue
159-
id="QueryPermissionsNeeded"
160-
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
161-
errorLine1=" val installedApps = packageManager.getInstalledApplications(PackageManager.GET_META_DATA).map { it.packageName }"
162-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
163-
<location
164-
file="src/main/java/com/duckduckgo/networkprotection/impl/autoexclude/AutoExcludeAppsRepository.kt"
165-
line="136"
166-
column="48"/>
167-
</issue>
168-
169-
<issue
170-
id="QueryPermissionsNeeded"
171-
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
172-
errorLine1=" installedApps = packageManager.getInstalledApplications(PackageManager.GET_META_DATA)"
173-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
174-
<location
175-
file="src/main/java/com/duckduckgo/networkprotection/impl/exclusion/ui/NetpAppExclusionListViewModel.kt"
176-
line="219"
177-
column="40"/>
178-
</issue>
179-
180-
<issue
181-
id="QueryPermissionsNeeded"
182-
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
183-
errorLine1=" packageManager.getInstalledApplications(PackageManager.GET_META_DATA).asSequence()"
184-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
185-
<location
186-
file="src/main/java/com/duckduckgo/networkprotection/impl/exclusion/NetpExclusionListRepository.kt"
187-
line="55"
188-
column="28"/>
189-
</issue>
190-
191-
<issue
192-
id="QueryPermissionsNeeded"
193-
message="As of Android 11, this method no longer returns information about all apps; see https://g.co/dev/packagevisibility for details"
194-
errorLine1=" return packageManager.getInstalledApplications(PackageManager.GET_META_DATA)"
195-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
196-
<location
197-
file="src/main/java/com/duckduckgo/networkprotection/impl/exclusion/systemapps/SystemAppsExclusionRepository.kt"
198-
line="203"
199-
column="31"/>
200-
</issue>
201-
202158
<issue
203159
id="MissingQuantity"
204160
message="For locale &quot;es&quot; (Spanish) the following quantity should also be defined: `many`"
@@ -1981,6 +1937,17 @@
19811937
column="5"/>
19821938
</issue>
19831939

1940+
<issue
1941+
id="StaticFieldLeak"
1942+
message="This field leaks a context object"
1943+
errorLine1=" private val context: Context,"
1944+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
1945+
<location
1946+
file="src/main/java/com/duckduckgo/networkprotection/impl/exclusion/ui/NetpAppExclusionListViewModel.kt"
1947+
line="92"
1948+
column="5"/>
1949+
</issue>
1950+
19841951
<issue
19851952
id="VectorPath"
19861953
message="Very long vector path (1122 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."

0 commit comments

Comments
 (0)