Skip to content

Commit

Permalink
Android: Ripple not displayed on the whole item (#2949)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1200905986587319/1204131202912051/f

### Description
Fixed ripple on view all recent activity item (replaced
`OneLineListItem` with `DaxTextView` as pe updated design).

### Steps to test this PR

- [x] Install from this branch.
- [x] Enable AppTP.
- [x] On `App Tracking protection` screen (main AppTP screen) once you
have more than 5 items in the `Activity` you should see the `View All
Recent Activity` item.
- [x] Tap on `View All Recent Activity` item and notice the ripple is
displayed over the whole item.

### UI changes
| Before  | After |
| ------ | ----- |

|![view_all_recent_activity_tapped_before](https://user-images.githubusercontent.com/7963079/224310217-ec2cc9e3-8af9-4c07-94fc-7377819b85b9.png)|![view_all_recent_activity_tapped_after](https://user-images.githubusercontent.com/7963079/224310894-c0000576-abd1-4533-8a07-f1bf1c7a9a69.png)|
  • Loading branch information
anikiki authored Mar 10, 2023
1 parent afbec29 commit 43a7e05
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class DeviceShieldTrackerActivity :
viewModel.onViewEvent(ViewEvent.AskToRemoveFeature)
}

binding.ctaShowAll.setClickListener {
binding.ctaShowAll.setOnClickListener {
viewModel.onViewEvent(ViewEvent.LaunchMostRecentActivity)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,20 @@
android:layout_height="0dp"
android:layout_weight="1" />

<com.duckduckgo.mobile.android.ui.view.listitem.OneLineListItem
<com.duckduckgo.mobile.android.ui.view.text.DaxTextView
android:id="@+id/cta_show_all"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:paddingStart="56dp"
android:layout_marginBottom="@dimen/keyline_4"
android:background="?attr/selectableItemBackground"
android:gravity="center_vertical"
android:minHeight="@dimen/keyline_7"
android:paddingStart="72dp"
android:paddingTop="@dimen/keyline_2"
android:paddingEnd="@dimen/keyline_4"
android:paddingBottom="@dimen/keyline_2"
android:visibility="gone"
app:primaryText="@string/atp_ActivityCtaShowAll" />
android:text="@string/atp_ActivityCtaShowAll"
android:visibility="gone" />

<com.duckduckgo.mobile.android.ui.view.divider.HorizontalDivider
android:layout_width="match_parent"
Expand Down

0 comments on commit 43a7e05

Please sign in to comment.