Hide the menu buttons in input screen when split omnibar enabled

Author: 0nko

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/viewmodel/InputScreenViewModel.kt

@@ -21,6 +21,8 @@ import androidx.lifecycle.ViewModel
 import androidx.lifecycle.ViewModelProvider
 import androidx.lifecycle.viewModelScope
 import com.duckduckgo.app.browser.UriString.Companion.isWebUrl
+import com.duckduckgo.app.browser.api.OmnibarRepository
+import com.duckduckgo.app.browser.omnibar.OmnibarType
 import com.duckduckgo.app.di.AppCoroutineScope
 import com.duckduckgo.app.statistics.pixels.Pixel
 import com.duckduckgo.app.statistics.pixels.Pixel.PixelType.Daily
@@ -126,6 +128,7 @@ class InputScreenViewModel @AssistedInject constructor(
     private val inputScreenDiscoveryFunnel: InputScreenDiscoveryFunnel,
     private val inputScreenSessionUsageMetric: InputScreenSessionUsageMetric,
     private val inputScreenConfigResolver: InputScreenConfigResolver,
+    private val omnibarRepository: OmnibarRepository,
 ) : ViewModel() {
 
     private val autoComplete: AutoComplete = autoCompleteFactory.create(
@@ -646,7 +649,8 @@ class InputScreenViewModel @AssistedInject constructor(
 
     private fun canShowMainButtons() = searchInputTextState.value.isEmpty() &&
         userSelectedMode == SEARCH &&
-        inputScreenConfigResolver.mainButtonsEnabled()
+        inputScreenConfigResolver.mainButtonsEnabled() &&
+        omnibarRepository.omnibarType != OmnibarType.SPLIT
 
     class InputScreenViewModelProviderFactory(
         private val assistedFactory: InputScreenViewModelFactory,

duckchat/duckchat-impl/src/test/kotlin/com/duckduckgo/duckchat/impl/ui/inputscreen/InputScreenViewModelTest.kt

@@ -4,6 +4,8 @@ import android.content.Intent
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import app.cash.turbine.test
+import com.duckduckgo.app.browser.api.OmnibarRepository
+import com.duckduckgo.app.browser.omnibar.OmnibarType
 import com.duckduckgo.app.statistics.pixels.Pixel
 import com.duckduckgo.app.statistics.pixels.Pixel.PixelType.Count
 import com.duckduckgo.app.statistics.pixels.Pixel.PixelType.Daily
@@ -82,6 +84,7 @@ class InputScreenViewModelTest {
     private val inputScreenDiscoveryFunnel: InputScreenDiscoveryFunnel = mock()
     private val inputScreenSessionUsageMetric: InputScreenSessionUsageMetric = mock()
     private val inputScreenConfigResolver: InputScreenConfigResolver = mock()
+    private val omnibarRepository: OmnibarRepository = mock()
 
     @Before
     fun setup() =
@@ -94,6 +97,7 @@ class InputScreenViewModelTest {
             whenever(duckChat.wasOpenedBefore()).thenReturn(false)
             whenever(inputScreenConfigResolver.useTopBar()).thenReturn(true)
             whenever(voiceSearchAvailability.isVoiceSearchAvailable).thenReturn(true)
+            whenever(omnibarRepository.omnibarType).thenReturn(OmnibarType.SINGLE_TOP)
         }
 
     private fun createViewModel(currentOmnibarText: String = ""): InputScreenViewModel =
@@ -111,6 +115,7 @@ class InputScreenViewModelTest {
             inputScreenDiscoveryFunnel = inputScreenDiscoveryFunnel,
             inputScreenSessionUsageMetric = inputScreenSessionUsageMetric,
             inputScreenConfigResolver = inputScreenConfigResolver,
+            omnibarRepository = omnibarRepository,
         )
 
     @Test
@@ -1970,4 +1975,29 @@ class InputScreenViewModelTest {
 
             verify(autoComplete).fireAutocompletePixel(suggestions, deviceAppSuggestion, experimentalInputScreen = true)
         }
+
+    @Test
+    fun `when using split omnibar and search mode selected with empty text then mainButtonsVisible is false`() =
+        runTest {
+            whenever(inputScreenConfigResolver.mainButtonsEnabled()).thenReturn(true)
+            whenever(omnibarRepository.omnibarType).thenReturn(OmnibarType.SPLIT)
+            val viewModel = createViewModel("")
+
+            viewModel.onSearchSelected()
+
+            assertFalse(viewModel.visibilityState.value.mainButtonsVisible)
+        }
+
+    @Test
+    fun `when user deletes all text in search mode and omnibar is SPLIT then buttons are not visible`() =
+        runTest {
+            whenever(inputScreenConfigResolver.mainButtonsEnabled()).thenReturn(true)
+            whenever(omnibarRepository.omnibarType).thenReturn(OmnibarType.SPLIT)
+            val viewModel = createViewModel("")
+            viewModel.onSearchSelected()
+
+            viewModel.onSearchInputTextChanged("")
+
+            assertFalse(viewModel.visibilityState.value.mainButtonsVisible)
+        }
 }