Skip to content

Commit 2a192dc

Browse files
mikescamellmarcosholgado
mikescamell
authored and
marcosholgado
committed
formatting
1 parent c1f978c commit 2a192dc

File tree

13 files changed

+46
-43
lines changed

13 files changed

+46
-43
lines changed

‎app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,6 @@ import com.duckduckgo.app.onboarding.store.OnboardingStore
168168
import com.duckduckgo.app.onboarding.store.UserStageStore
169169
import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.ExtendedOnboardingFeatureToggles
170170
import com.duckduckgo.app.onboardingdesignexperiment.OnboardingDesignExperimentManager
171-
import com.duckduckgo.app.onboardingdesignexperiment.OnboardingDesignExperimentToggles
172-
import com.duckduckgo.app.pixels.AppPixelName
173171
import com.duckduckgo.app.pixels.AppPixelName.AUTOCOMPLETE_BANNER_SHOWN
174172
import com.duckduckgo.app.pixels.AppPixelName.DUCK_PLAYER_SETTING_ALWAYS_DUCK_PLAYER
175173
import com.duckduckgo.app.pixels.AppPixelName.DUCK_PLAYER_SETTING_ALWAYS_OVERLAY_YOUTUBE
@@ -290,9 +288,7 @@ import com.duckduckgo.subscriptions.api.SubscriptionRebrandingFeatureToggle
290288
import com.duckduckgo.subscriptions.api.Subscriptions
291289
import com.duckduckgo.subscriptions.api.SubscriptionsJSHelper
292290
import com.duckduckgo.sync.api.favicons.FaviconsFetchingPrompt
293-
import com.duckduckgo.voice.api.VoiceSearchAvailability
294291
import com.duckduckgo.voice.api.VoiceSearchAvailabilityPixelLogger
295-
import dagger.Lazy
296292
import java.io.File
297293
import java.math.BigInteger
298294
import java.security.cert.X509Certificate
@@ -6643,7 +6639,7 @@ class BrowserTabViewModelTest {
66436639
}
66446640

66456641
@Test
6646-
fun whenSetOnboardingDialogBackgroundWithBuckOnboardingEnabledAndLightModeEnabledThenSetOnboardingDialogBackgroundColorCommandIssuedWithCorrectColor() {
6642+
fun whenSetOnboardingDialogBackgroundWithBuckOnboardingAndLightModeEnabledThenSetOnboardingDialogBackgroundColorCommandIssuedWithCorrectColor() {
66476643
whenever(mockOnboardingDesignExperimentManager.isBuckEnrolledAndEnabled()).thenReturn(true)
66486644

66496645
testee.setOnboardingDialogBackground(lightModeEnabled = true)
@@ -6654,7 +6650,7 @@ class BrowserTabViewModelTest {
66546650
}
66556651

66566652
@Test
6657-
fun whenSetOnboardingDialogBackgroundWithBuckOnboardingEnabledAndDarkModeEnabledThenSetOnboardingDialogBackgroundColorCommandIssuedWithCorrectColor() {
6653+
fun whenSetOnboardingDialogBackgroundWithBuckOnboardinAndDarkModeEnabledThenSetOnboardingDialogBackgroundColorCommandIssuedWithCorrectColor() {
66586654
whenever(mockOnboardingDesignExperimentManager.isBuckEnrolledAndEnabled()).thenReturn(true)
66596655

66606656
testee.setOnboardingDialogBackground(lightModeEnabled = false)
@@ -6938,7 +6934,6 @@ class BrowserTabViewModelTest {
69386934
verify(mockOnboardingDesignExperimentManager).fireSiteSuggestionOptionSelectedPixel(1)
69396935
}
69406936

6941-
69426937
@Test
69436938
fun whenUserSubmittedQueryNotSuggestedSearchOptionThenFireSearchOrNavCustomPixel() = runTest {
69446939
whenever(mockOmnibarConverter.convertQueryToUrl("custom query", null)).thenReturn("custom query")

‎app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@ import com.duckduckgo.app.global.view.NonDismissibleBehavior
198198
import com.duckduckgo.app.global.view.launchDefaultAppActivity
199199
import com.duckduckgo.app.global.view.renderIfChanged
200200
import com.duckduckgo.app.onboardingdesignexperiment.OnboardingDesignExperimentManager
201-
import com.duckduckgo.app.onboardingdesignexperiment.OnboardingDesignExperimentToggles
202201
import com.duckduckgo.app.pixels.AppPixelName
203202
import com.duckduckgo.app.settings.db.SettingsDataStore
204203
import com.duckduckgo.app.statistics.pixels.Pixel

‎app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ import com.duckduckgo.app.global.model.domain
239239
import com.duckduckgo.app.global.model.domainMatchesUrl
240240
import com.duckduckgo.app.location.data.LocationPermissionType
241241
import com.duckduckgo.app.onboardingdesignexperiment.OnboardingDesignExperimentManager
242-
import com.duckduckgo.app.onboardingdesignexperiment.OnboardingDesignExperimentToggles
243242
import com.duckduckgo.app.pixels.AppPixelName
244243
import com.duckduckgo.app.pixels.AppPixelName.AUTOCOMPLETE_BANNER_DISMISSED
245244
import com.duckduckgo.app.pixels.AppPixelName.AUTOCOMPLETE_BANNER_SHOWN

‎app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ sealed class OnboardingDaxDialogCta(
447447
override val appInstallStore: AppInstallStore,
448448
val trackers: List<Entity>,
449449
val settingsDataStore: SettingsDataStore,
450-
private val onboardingDesignExperimentManager : OnboardingDesignExperimentManager,
450+
private val onboardingDesignExperimentManager: OnboardingDesignExperimentManager,
451451
) : OnboardingDaxDialogCta(
452452
CtaId.DAX_DIALOG_TRACKERS_FOUND,
453453
null,
@@ -550,7 +550,7 @@ sealed class OnboardingDaxDialogCta(
550550
override val appInstallStore: AppInstallStore,
551551
val network: String,
552552
private val siteHost: String,
553-
private val onboardingDesignExperimentManager : OnboardingDesignExperimentManager,
553+
private val onboardingDesignExperimentManager: OnboardingDesignExperimentManager,
554554
) : OnboardingDaxDialogCta(
555555
CtaId.DAX_DIALOG_NETWORK,
556556
null,
@@ -631,7 +631,7 @@ sealed class OnboardingDaxDialogCta(
631631
class DaxNoTrackersCta(
632632
override val onboardingStore: OnboardingStore,
633633
override val appInstallStore: AppInstallStore,
634-
private val onboardingDesignExperimentManager : OnboardingDesignExperimentManager,
634+
private val onboardingDesignExperimentManager: OnboardingDesignExperimentManager,
635635
) : OnboardingDaxDialogCta(
636636
CtaId.DAX_DIALOG_OTHER,
637637
R.string.daxNonSerpCtaText,
@@ -753,7 +753,7 @@ sealed class OnboardingDaxDialogCta(
753753
class DaxSiteSuggestionsCta(
754754
override val onboardingStore: OnboardingStore,
755755
override val appInstallStore: AppInstallStore,
756-
private val onboardingDesignExperimentManager : OnboardingDesignExperimentManager,
756+
private val onboardingDesignExperimentManager: OnboardingDesignExperimentManager,
757757
private val onSiteSuggestionOptionClicked: (index: Int) -> Unit, // used to fire experiment pixel
758758
) : OnboardingDaxDialogCta(
759759
CtaId.DAX_INTRO_VISIT_SITE,
@@ -783,7 +783,7 @@ sealed class OnboardingDaxDialogCta(
783783
onSuggestedOptionClicked = { option, index ->
784784
onSuggestedOptionClicked?.invoke(option)
785785
onSiteSuggestionOptionClicked.invoke(index)
786-
}
786+
},
787787
)
788788
}
789789
onboardingDesignExperimentManager.isBbEnrolledAndEnabled() -> {
@@ -1031,7 +1031,7 @@ sealed class OnboardingDaxDialogCta(
10311031
class DaxEndCta(
10321032
override val onboardingStore: OnboardingStore,
10331033
override val appInstallStore: AppInstallStore,
1034-
private val onboardingDesignExperimentManager : OnboardingDesignExperimentManager,
1034+
private val onboardingDesignExperimentManager: OnboardingDesignExperimentManager,
10351035
) : OnboardingDaxDialogCta(
10361036
CtaId.DAX_END,
10371037
R.string.highlightsOnboardingEndDaxDialogDescription,
@@ -1057,7 +1057,7 @@ sealed class OnboardingDaxDialogCta(
10571057
val context = binding.root.context
10581058

10591059
when {
1060-
onboardingDesignExperimentManager.isBuckEnrolledAndEnabled()-> {
1060+
onboardingDesignExperimentManager.isBuckEnrolledAndEnabled() -> {
10611061
setBuckOnboardingDialogView(
10621062
message = description?.let { context.getString(it) }.orEmpty(),
10631063
primaryCtaText = buttonText?.let { context.getString(it) },

‎app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,12 @@ class CtaViewModel @Inject constructor(
225225
suspend fun getSiteSuggestionsDialogCta(onSiteSuggestionOptionClicked: (index: Int) -> Unit): OnboardingDaxDialogCta? {
226226
return withContext(dispatchers.io()) {
227227
if (!daxOnboardingActive() || !canShowDaxIntroVisitSiteCta()) return@withContext null
228-
OnboardingDaxDialogCta.DaxSiteSuggestionsCta(onboardingStore, appInstallStore, onboardingDesignExperimentManager, onSiteSuggestionOptionClicked)
228+
OnboardingDaxDialogCta.DaxSiteSuggestionsCta(
229+
onboardingStore,
230+
appInstallStore,
231+
onboardingDesignExperimentManager,
232+
onSiteSuggestionOptionClicked,
233+
)
229234
}
230235
}
231236

‎app/src/main/java/com/duckduckgo/app/onboardingdesignexperiment/OnboardingDesignExperimentCountDataStore.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ private const val KEY_SERP_VISIT_COUNT = "serp_visit_count"
4343
@ContributesBinding(AppScope::class)
4444
@SingleInstanceIn(AppScope::class)
4545
class SharedPreferencesOnboardingDesignExperimentCountDataStore @Inject constructor(
46-
private val dispatcherProvider: DispatcherProvider,
47-
@OnboardingVisitCount private val store: DataStore<Preferences>,
46+
private val dispatcherProvider: DispatcherProvider,
47+
@OnboardingVisitCount private val store: DataStore<Preferences>,
4848
) : OnboardingDesignExperimentCountDataStore {
4949

5050
override suspend fun increaseSiteVisitCount(): Int {

‎app/src/main/java/com/duckduckgo/app/onboardingdesignexperiment/OnboardingDesignExperimentManager.kt‎

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -188,17 +188,17 @@ class RealOnboardingDesignExperimentManager @Inject constructor(
188188
}
189189

190190
override suspend fun fireInContextDialogShownPixel(cta: Cta?) {
191-
when(cta) {
191+
when (cta) {
192192
is DaxBubbleCta -> {
193-
when(cta) {
193+
when (cta) {
194194
is DaxBubbleCta.DaxIntroSearchOptionsCta -> fireTryASearchDisplayedPixel()
195195
is DaxBubbleCta.DaxIntroVisitSiteOptionsCta -> fireVisitSitePromptDisplayedNewTabPixel()
196196
is DaxBubbleCta.DaxEndCta -> fireFinalOnboardingScreenDisplayedPixel()
197197
is DaxBubbleCta.DaxPrivacyProCta -> Unit // No pixel for this CTA
198198
}
199199
}
200-
is OnboardingDaxDialogCta ->{
201-
when(cta) {
200+
is OnboardingDaxDialogCta -> {
201+
when (cta) {
202202
is OnboardingDaxDialogCta.DaxSerpCta -> fireMessageOnSerpDisplayedPixel()
203203
is OnboardingDaxDialogCta.DaxSiteSuggestionsCta -> fireVisitSitePromptDisplayedAdjacentPixel()
204204
is OnboardingDaxDialogCta.DaxTrackersBlockedCta -> fireTrackersBlockedMessageDisplayedPixel()
@@ -215,32 +215,33 @@ class RealOnboardingDesignExperimentManager @Inject constructor(
215215
cta: Cta,
216216
index: Int,
217217
) {
218-
when(cta) {
218+
when (cta) {
219219
is DaxBubbleCta.DaxIntroSearchOptionsCta -> {
220-
when(index) {
220+
when (index) {
221221
0 -> fireFirstSearchSuggestionPixel()
222222
1 -> fireSecondSearchSuggestionPixel()
223223
2 -> fireThirdSearchSuggestionPixel()
224224
else -> Unit // only 3 options are available
225225
}
226226
}
227227
is DaxBubbleCta.DaxIntroVisitSiteOptionsCta,
228-
is OnboardingDaxDialogCta.DaxSiteSuggestionsCta -> fireSiteSuggestionOptionSelectedPixel(index)
228+
is OnboardingDaxDialogCta.DaxSiteSuggestionsCta,
229+
-> fireSiteSuggestionOptionSelectedPixel(index)
229230
}
230231
}
231232

232233
override suspend fun fireSiteSuggestionOptionSelectedPixel(index: Int) {
233-
when(index) {
234-
0 -> fireFirstSiteSuggestionPixel()
235-
1 -> fireSecondSiteSuggestionPixel()
236-
2 -> fireThirdSiteSuggestionPixel()
237-
else -> Unit // only 3 options are available
238-
}
234+
when (index) {
235+
0 -> fireFirstSiteSuggestionPixel()
236+
1 -> fireSecondSiteSuggestionPixel()
237+
2 -> fireThirdSiteSuggestionPixel()
238+
else -> Unit // only 3 options are available
239+
}
239240
}
240241

241242
override suspend fun onWebPageFinishedLoading(url: String?) {
242243
if (url == null) return
243-
if(duckDuckGoUrlDetector.isDuckDuckGoUrl(url)) {
244+
if (duckDuckGoUrlDetector.isDuckDuckGoUrl(url)) {
244245
fireSecondSerpVisitPixel()
245246
} else {
246247
fireSecondSiteVisitPixel()

‎app/src/test/java/com/duckduckgo/app/cta/ui/CtaTest.kt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import com.duckduckgo.app.trackerdetection.model.Entity
3434
import com.duckduckgo.app.trackerdetection.model.TrackerStatus
3535
import com.duckduckgo.app.trackerdetection.model.TrackerType
3636
import com.duckduckgo.app.trackerdetection.model.TrackingEvent
37-
import com.duckduckgo.feature.toggles.api.Toggle
3837
import java.util.concurrent.TimeUnit
3938
import org.junit.Assert.assertEquals
4039
import org.junit.Assert.assertFalse
@@ -44,7 +43,6 @@ import org.junit.Test
4443
import org.mockito.Mock
4544
import org.mockito.MockitoAnnotations
4645
import org.mockito.kotlin.any
47-
import org.mockito.kotlin.doReturn
4846
import org.mockito.kotlin.mock
4947
import org.mockito.kotlin.whenever
5048

‎app/src/test/java/com/duckduckgo/app/onboarding/onboardingdesignexperiment/OnboardingDesignExperimentManagerTest.kt‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,9 @@ class OnboardingDesignExperimentManagerTest {
166166
whenever(onboardingDesignExperimentToggles.onboardingDesignExperimentAug25()).thenReturn(mockToggle)
167167
whenever(mockToggle.isEnabled()).thenReturn(true)
168168
whenever(mockToggle.getCohort()).thenReturn(mockCohort)
169-
whenever(mockToggle.getCohort()!!.name).thenReturn(OnboardingDesignExperimentToggles.OnboardingDesignExperimentCohort.MODIFIED_CONTROL.cohortName)
169+
whenever(mockToggle.getCohort()!!.name).thenReturn(
170+
OnboardingDesignExperimentToggles.OnboardingDesignExperimentCohort.MODIFIED_CONTROL.cohortName,
171+
)
170172

171173
whenever(appBuildConfig.sdkInt).thenReturn(33)
172174
whenever(appBuildConfig.isAppReinstall()).thenReturn(false)
@@ -383,7 +385,9 @@ class OnboardingDesignExperimentManagerTest {
383385

384386
@Test
385387
fun whenFireInContextDialogShownPixelWithDaxTrackersBlockedCtaThenCorrectPixelFired() = runTest {
386-
testee.fireInContextDialogShownPixel(OnboardingDaxDialogCta.DaxTrackersBlockedCta(onboardingStore, appInstallStore, emptyList(), settingsDataStore, testee))
388+
testee.fireInContextDialogShownPixel(
389+
OnboardingDaxDialogCta.DaxTrackersBlockedCta(onboardingStore, appInstallStore, emptyList(), settingsDataStore, testee),
390+
)
387391
verify(onboardingExperimentMetricsPixelPlugin).getTrackersBlockedMessageDisplayedMetric()
388392
}
389393

@@ -395,7 +399,9 @@ class OnboardingDesignExperimentManagerTest {
395399

396400
@Test
397401
fun whenFireInContextDialogShownPixelWithDaxMainNetworkCtaThenCorrectPixelFired() = runTest {
398-
testee.fireInContextDialogShownPixel(OnboardingDaxDialogCta.DaxMainNetworkCta(onboardingStore, appInstallStore, "Facebook", "facebook.com", testee))
402+
testee.fireInContextDialogShownPixel(
403+
OnboardingDaxDialogCta.DaxMainNetworkCta(onboardingStore, appInstallStore, "Facebook", "facebook.com", testee),
404+
)
399405
verify(onboardingExperimentMetricsPixelPlugin).getTrackerNetworkMessageDisplayedMetric()
400406
}
401407

‎app/src/test/java/com/duckduckgo/app/onboarding/ui/page/WelcomePageViewModelTest.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ class WelcomePageViewModelTest {
155155

156156
@Test
157157
fun givenComparisonChartDialogWhenDDGIsDefaultBrowserThenFireChooseBrowserPixel() = runTest {
158-
whenever(mockDefaultRoleBrowserDialog.shouldShowDialog()).thenReturn(false)
158+
whenever(mockDefaultRoleBrowserDialog.shouldShowDialog()).thenReturn(false)
159159
testee.onPrimaryCtaClicked(PreOnboardingDialogType.COMPARISON_CHART)
160160

161161
verify(mockOnboardingDesignExperimentManager).fireChooseBrowserPixel()

0 commit comments

Comments
 (0)