Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENUM type support #100

Open
wuputah opened this issue Aug 7, 2024 · 3 comments
Open

ENUM type support #100

wuputah opened this issue Aug 7, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@wuputah
Copy link
Collaborator

wuputah commented Aug 7, 2024

No description provided.

@Reminiscent
Copy link
Contributor

Hi, I'm very interested in this task. Could I work on it? Thank you very much! @wuputah @Tishj

@wuputah
Copy link
Collaborator Author

wuputah commented Aug 13, 2024

Thanks for your interest! I defer to @Tishj there on whether that makes sense and what the implementation plan should be. Most likely this should build on top of #56 / #97 where enums are copied from Postgres to the DuckDB catalog.

@Reminiscent
Copy link
Contributor

@wuputah Thanks for your suggestion. I'll try to implement some types which are compatible now. I have some questions want to ask.

  1. Are there any discuss about how to implement some types which are incompatible? And what is the principle.
  2. Could you elaborate on the relationship between the catalog system implemented in this patch and the support for enum types? How does the catalog system specifically enable or facilitate the implementation of enum type support? Can you provide a concrete example of how the catalog changes in this patch would be utilized when implementing enum type support in pg_duckdb? Thanks!

@wuputah wuputah added this to the 0.1.0 milestone Sep 16, 2024
@JelteF JelteF modified the milestones: 0.1.0 code complete, 0.2.0 Sep 30, 2024
@JelteF JelteF added the enhancement New feature or request label Sep 30, 2024
@wuputah wuputah removed this from pg_duckdb Oct 21, 2024
@JelteF JelteF modified the milestones: 0.2.0, 0.3.0 Dec 10, 2024
@JelteF JelteF modified the milestones: 0.3.0, 0.4.0 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants