Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make duckdb_register as a generic function #98

Open
eitsupi opened this issue Mar 4, 2024 · 5 comments
Open

Make duckdb_register as a generic function #98

eitsupi opened this issue Mar 4, 2024 · 5 comments

Comments

@eitsupi
Copy link
Contributor

eitsupi commented Mar 4, 2024

Currently there is a separate function named duckdb_register_arrow available apart from duckdb_register, but I am wondering if these can be made into one S3 generic function.

@krlmlr
Copy link
Collaborator

krlmlr commented Mar 21, 2024

Thanks. What other use cases do you have in mind?

@eitsupi
Copy link
Contributor Author

eitsupi commented Mar 21, 2024

What other use cases do you have in mind?

Not that I have any other use cases, but I felt that I didn't want to use another function when supporting Apache Arrow implementations outside of the arrow package in the future.

@krlmlr
Copy link
Collaborator

krlmlr commented Mar 22, 2024

What do you mean by "supporting Apache Arrow implementations" -- nanoarrow?

What other table-like objects would we want to register?

@eitsupi
Copy link
Contributor Author

eitsupi commented Mar 22, 2024

I assumed something like nanoarrow array or polars DataFrame.
Of course to support them, the C++ code in the duckdb package would have to be changed, I suppose.

@krlmlr
Copy link
Collaborator

krlmlr commented Mar 22, 2024

But if we change the C++ code anyway, we can surely add a new duckdb_register_*() function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants