From 6d0c9b6daa02e6051442c17f9b043b9a0e79d419 Mon Sep 17 00:00:00 2001 From: Carlo Piovesan Date: Mon, 6 May 2024 11:25:45 +0200 Subject: [PATCH] Add back Node 22 also for Windows There was a compilation problem, that appears to have gone away in the mean time, probably node side --- .github/workflows/NodeJS.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/NodeJS.yml b/.github/workflows/NodeJS.yml index f9f0c695..60876a34 100644 --- a/.github/workflows/NodeJS.yml +++ b/.github/workflows/NodeJS.yml @@ -41,7 +41,7 @@ jobs: name: node.js Linux runs-on: ubuntu-20.04 needs: set-up-npm - continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }} + continue-on-error: ${{ matrix.node == '12' || matrix.node == '14' || matrix.node == '16' || matrix.node == '17' }} env: TARGET_ARCH: ${{ matrix.target_arch }} DUCKDB_NODE_BUILD_CACHE: 0 @@ -119,7 +119,7 @@ jobs: name: node.js OSX runs-on: macos-14 needs: set-up-npm - continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }} + continue-on-error: ${{ matrix.node == '16' || matrix.node == '17' }} strategy: matrix: target_arch: [ arm64 ] @@ -245,13 +245,13 @@ jobs: name: node.js Windows runs-on: windows-latest needs: set-up-npm - continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }} + continue-on-error: ${{ matrix.node == '16' || matrix.node == '17' }} env: npm_config_msvs_version: 2019 strategy: matrix: - node: [ '16', '17', '18', '19', '20', '21'] + node: [ '16', '17', '18', '19', '20', '21', '22'] isRelease: - ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }} exclude: