-
-
Notifications
You must be signed in to change notification settings - Fork 87
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: dtolnay/async-trait
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.61
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: dtolnay/async-trait
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.63
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 11 commits
- 6 files changed
- 1 contributor
Commits on Jan 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8206008 - Browse repository at this point
Copy the full SHA 8206008View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4c19da - Browse repository at this point
Copy the full SHA b4c19daView commit details -
Merge pull request #230 from dtolnay/definedhere
Improve spans of named lifetimes generated from elided lifetimes
Configuration menu - View commit details
-
Copy full SHA for 861b6bc - Browse repository at this point
Copy the full SHA 861b6bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d71c74d - Browse repository at this point
Copy the full SHA d71c74dView commit details
Commits on Jan 22, 2023
-
Add regression test for issue 232
Currently fails to compile: error: future cannot be sent between threads safely --> tests/test.rs:1506:41 | 1506 | async fn take_ref(&self, _: &T) {} | ^^ future created by async block is not `Send` | note: captured value is not `Send` because `&` references cannot be sent unless their referent is `Sync` --> tests/test.rs:1506:34 | 1504 | #[async_trait] | -------------- in this procedural macro expansion 1505 | impl<T> Generic<T> for One { 1506 | async fn take_ref(&self, _: &T) {} | ^ has type `&T` which is not `Send`, because `T` is not `Sync` = note: required for the cast from `[async block@tests/test.rs:1506:41: 1506:43]` to the object type `dyn futures::Future<Output = ()> + std::marker::Send` = note: this error originates in the attribute macro `async_trait` (in Nightly builds, run with -Z macro-backtrace for more info) help: consider restricting type parameter `T` | 1505 | impl<T: std::marker::Sync> Generic<T> for One { | +++++++++++++++++++ error[E0277]: `T` cannot be shared between threads safely --> tests/test.rs:1523:60 | 1523 | async fn take_ref(&self, (_a, _b, _c): &(T, T, T)) {} | ^^ `T` cannot be shared between threads safely | = note: required because it appears within the type `(T, T, T)` = note: required for `&(T, T, T)` to implement `std::marker::Send` note: required because it's used within this `async` block --> tests/test.rs:1523:60 | 1523 | async fn take_ref(&self, (_a, _b, _c): &(T, T, T)) {} | ^^ = note: required for the cast from `[async block@tests/test.rs:1523:60: 1523:62]` to the object type `dyn futures::Future<Output = ()> + std::marker::Send` help: consider restricting type parameter `T` | 1522 | impl<T: std::marker::Sync> Generic<(T, T, T)> for Three { | +++++++++++++++++++
Configuration menu - View commit details
-
Copy full SHA for 70bf4b0 - Browse repository at this point
Copy the full SHA 70bf4b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba93025 - Browse repository at this point
Copy the full SHA ba93025View commit details -
Merge pull request #233 from dtolnay/reference
Bypass Sync bound implied by non-existent drop of reference
Configuration menu - View commit details
-
Copy full SHA for 125917f - Browse repository at this point
Copy the full SHA 125917fView commit details -
Add regression test for issue 234
Currently fails to compile: error: changes to closure capture in Rust 2021 will affect drop order --> tests/test.rs:1549:59 | 1549 | async fn f(Tuple(_, _int): Tuple<Droppable, i32>) {} | -------------- ^- | | | | | in Rust 2018, `__arg0` is dropped here, but in Rust 2021, only `__arg0.1` will be dropped here as part of the closure | in Rust 2018, this closure captures all of `__arg0`, but in Rust 2021, it will only capture `__arg0.1` | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/disjoint-capture-in-closures.html> note: the lint level is defined here --> tests/test.rs:5:9 | 5 | #![deny(rust_2021_compatibility)] | ^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[deny(rust_2021_incompatible_closure_captures)]` implied by `#[deny(rust_2021_compatibility)]` help: add a dummy let to cause `__arg0` to be fully captured | 1549 | async fn f(Tuple(_, _int): Tuple<Droppable, i32>) { let _ = &__arg0;} | ++++++++++++++++ error: changes to closure capture in Rust 2021 will affect drop order --> tests/test.rs:1556:66 | 1556 | async fn f(Tuple { 1: _int, .. }: Tuple<Droppable, i32>) {} | --------------------- ^- | | | | | in Rust 2018, `__arg0` is dropped here, but in Rust 2021, only `__arg0.1` will be dropped here as part of the closure | in Rust 2018, this closure captures all of `__arg0`, but in Rust 2021, it will only capture `__arg0.1` | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/disjoint-capture-in-closures.html> help: add a dummy let to cause `__arg0` to be fully captured | 1556 | async fn f(Tuple { 1: _int, .. }: Tuple<Droppable, i32>) { let _ = &__arg0;} | ++++++++++++++++
Configuration menu - View commit details
-
Copy full SHA for 80a9c2c - Browse repository at this point
Copy the full SHA 80a9c2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c2e90a - Browse repository at this point
Copy the full SHA 1c2e90aView commit details -
Merge pull request #235 from dtolnay/patterns
Make expansion of nested `_` and `..` patterns edition independent
Configuration menu - View commit details
-
Copy full SHA for f88c287 - Browse repository at this point
Copy the full SHA f88c287View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36bcff4 - Browse repository at this point
Copy the full SHA 36bcff4View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.1.61...0.1.63