[Nebius] Add spot instances and B200 support #165 #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus, it adds B200 GPU for Nebius
jvstme
approved these changes
Aug 8, 2025
| ) -> RawCatalogItem: | ||
| def get_price(regular_price: float, spot_price: Optional[float]) -> float: | ||
| """Helper function to get the appropriate price based on spot availability""" | ||
| return spot_price if spot and spot_price is not None else regular_price |
There was a problem hiding this comment.
(nit) If spot is True, but spot_price is None, I'd expect the function to raise an exception rather than default to regular_price. Otherwise, future bugs can go unnoticed.
Suggested change
| return spot_price if spot and spot_price is not None else regular_price | |
| if spot: | |
| if spot_price is None: | |
| raise ValueError("Spot price missing") | |
| return spot_price | |
| return regular_price |
Co-authored-by: jvstme <36324149+jvstme@users.noreply.github.com>
peterschmidt85
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus, it adds B200 GPU for Nebius