Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add W argument #39

Closed
dscolby opened this issue Mar 28, 2024 · 2 comments
Closed

Add W argument #39

dscolby opened this issue Mar 28, 2024 · 2 comments
Labels
reference So we don't try to address the same problem again.

Comments

@dscolby
Copy link
Owner

dscolby commented Mar 28, 2024

Add W parameter for covariates for the treatment function in double machine learning, X learning, doubly robust estimation, and R learning.
@dscolby dscolby added wontfix This will not be worked on reference So we don't try to address the same problem again. labels Apr 29, 2024
@dscolby
Copy link
Owner Author

dscolby commented Apr 29, 2024

This seems kind of unnecessary. The original paper doesn't use a W parameter. EconML does this so let you include a bunch of characteristics in a model and only estimate the CATE conditional on a subset of those variables. Hence, the W is the set of all potential confounders and the X are the variables of interest. I think we can close this out (at least for now).

@dscolby dscolby closed this as completed Apr 29, 2024
@dscolby dscolby reopened this May 4, 2024
@dscolby dscolby removed the wontfix This will not be worked on label May 4, 2024
@dscolby
Copy link
Owner Author

dscolby commented May 5, 2024

Completed with commit b84bb08.

@dscolby dscolby closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reference So we don't try to address the same problem again.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dscolby