Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Bipartite Feature Memoization #78

Open
AntoinePrv opened this issue Aug 10, 2020 · 0 comments · Fixed by #137
Open

Node Bipartite Feature Memoization #78

AntoinePrv opened this issue Aug 10, 2020 · 0 comments · Fixed by #137
Labels
type/enhancement 🚀 New feature or request

Comments

@AntoinePrv
Copy link
Member

Describe the problem or improvement suggested

Some feature in the NodeBipartite observation only need to be computed on reset and not on all transitions.

Describe the solution you would like

Cache the features:

  • Cache the whole observation
  • Update features that can change

Describe alternatives you have considered

Additional context
@AntoinePrv AntoinePrv added the type/enhancement 🚀 New feature or request label Aug 10, 2020
@AntoinePrv AntoinePrv mentioned this issue Feb 25, 2021
Merged
4 tasks
@AntoinePrv AntoinePrv linked a pull request Apr 7, 2021 that will close this issue
Add manual cache to NodeBipartite #137
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add manual cache to NodeBipartite ds4dm/ecole
1 participant
@AntoinePrv