Description
I'm running into an error running patch-package on a specific package. I noticed that the patch file removes a README.md file. This is due to my .yarnclean file defining *.md files for removal. So, I believe yarn install is running - removing the markdown file, then patch-package is running and becoming confused with the removal of the md file somehow?
Removing the *.md line from my .yarnclean file caused the patch to be successful: cypress-io/cypress@38469fd
I think .yarnclean is not playing well with patch-package. Maybe this should be updated to ignore files similar to how .gitignore` directories are ignored?
patch-package/src/makePatch.ts
Line 265 in bd2e9a4
Error
**ERROR** Failed to apply patch for package snap-shot-core at path
node_modules/snap-shot-core
This error was caused because patch-package cannot apply the following patch file:
patches/snap-shot-core+10.2.4.dev.patch
Try removing node_modules and trying again. If that doesn't work, maybe there was
an accidental change made to the patch file? Try recreating it by manually
editing the appropriate files and running:
patch-package snap-shot-core
If that doesn't work, then it's a bug in patch-package, so please submit a bug
report. Thanks!
https://github.com/ds300/patch-package/issues
---
patch-package finished with 1 error(s).
node:child_process:966
throw err;
^
Error: Command failed: patch-package && lerna run rebuild-better-sqlite3 --scope @packages/server
You can see how the PR diff including removing the Readme file: https://github.com/cypress-io/cypress/pull/31449/files#diff-6d4ec7fb70a72c8193e10a8c390b904e6313087e19b3d2a191d466cc31063441
This seemed to work on other patches I made though - like here - so I'm not sure why this one failed.