Skip to content

Make @safe((TypeError, ValueError)) variant - #1199

Merged
sobolevn merged 6 commits into
masterfrom
issue-605
Dec 31, 2021
Merged

Make @safe((TypeError, ValueError)) variant#1199
sobolevn merged 6 commits into
masterfrom
issue-605

Conversation

@thepabloaguilar

Copy link
Copy Markdown
Member

Make @safe((TypeError, ValueError)) variant

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #605

@codecov

codecov Bot commented Dec 30, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1199 (0882c19) into master (8824d0f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1199   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines         2414      2425   +11     
  Branches       208       211    +3     
=========================================
+ Hits          2414      2425   +11     
Impacted Files Coverage Δ
returns/result.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8824d0f...0882c19. Read the comment docs.

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you!

Two minor things:

  1. Better example in the docs
  2. Better arg name

Comment thread docs/pages/result.rst
Comment thread returns/result.py Outdated
Comment thread typesafety/test_result/test_safe.yml
Comment thread typesafety/test_result/test_safe.yml
@sobolevn
sobolevn merged commit 82a40dc into master Dec 31, 2021
@sobolevn
sobolevn deleted the issue-605 branch December 31, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Make @safe(exceptions=(TypeError, ValueError)) variant

2 participants