Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow info file editing when the repository is not on d.o #368

Merged
merged 1 commit into from
Jan 21, 2014
Merged

allow info file editing when the repository is not on d.o #368

merged 1 commit into from
Jan 21, 2014

Conversation

bircher
Copy link
Contributor

@bircher bircher commented Jan 11, 2014

@bircher
Copy link
Contributor Author

bircher commented Jan 11, 2014

finally acted upon #187

@ghost ghost assigned jhedstrom Jan 15, 2014
@jhedstrom
Copy link
Member

This feature makes sense to me--any chance for a test to be added?

@bircher
Copy link
Contributor Author

bircher commented Jan 21, 2014

Hello,
I am not very familiar with writing tests and I didn't find the test that specifically tests for the no-gitinfofile option that I could get inspired from.

From what I understand, one would have to have a module hosted on for example github and add it with a new makefile.
Should the test assert that the info file is not written when the option is missing or just that it is when the option is there?

@jhedstrom
Copy link
Member

I think you're right in that no .info file rewriting is currently being tested. I'll add these tests. In the meantime, this looks good to me. Thanks!

jhedstrom added a commit that referenced this pull request Jan 21, 2014
Allow info file editing when the repository is not on d.o.
@jhedstrom jhedstrom merged commit 26f44a4 into drush-ops:master Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants