Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D10 comaptibility #41

Open
jan-steffen opened this issue Sep 12, 2023 · 2 comments · May be fixed by #43
Open

D10 comaptibility #41

jan-steffen opened this issue Sep 12, 2023 · 2 comments · May be fixed by #43

Comments

@jan-steffen
Copy link

jan-steffen commented Sep 12, 2023 •
edited
Loading

Hi together

We need to make this module d10 compatible.
Basically just the info files core_version_requirement needs to be adjusted

Could you help me with the workflow of getting this into a graphql_views release?

Thanks and regards,
Jan
@jan-steffen
Copy link
Author

graphql-views-41-d10-compatibility.patch

@kwiechmann
Copy link

kwiechmann commented Oct 26, 2023 •
edited
Loading

Have similar patch but also remove the core: 8.x lines in both graphql_views.info.yml and graphql_views_test.info.yml This core keyan be dropped if the core_version_requirement for Drupal 8 is switched to ^8.8 or left in if the minimum version is raised to 8.8.

@luksak luksak linked a pull request Nov 9, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing Drupal 10 compatibility issues luksak/graphql-views
2 participants
@kwiechmann @jan-steffen