Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Select inherit colors and z-order #93

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Fix - Select inherit colors and z-order #93

merged 4 commits into from
Oct 17, 2023

Conversation

leandroppf
Copy link
Contributor

📝 Description

  • Fixed select inherit colors
  • Fixed select z-order conflicting with Dialog
  • Added class merge helper
  • Updated Docs

🚀 Behavior Changes

  • The text of select was always in a light gray color(text-gray). The text respect inherit colors now.
  • The select options were being hidden by Dialog

💣 Is this a breaking change (Yes/No):

No

@leandroppf leandroppf linked an issue Oct 16, 2023 that may be closed by this pull request
[BUG] - Adicionar currentColor no Select #90
Closed
@github-actions github-actions bot added the bugfix Something isn't working label Oct 16, 2023
YaGRRusso
YaGRRusso approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@YaGRRusso YaGRRusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boa demais!

@leandroppf leandroppf merged commit 7ad8df5 into main Oct 17, 2023
1 check passed
@leandroppf leandroppf deleted the fix-select-issues branch October 17, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaGRRusso YaGRRusso YaGRRusso approved these changes

@onhate onhate Awaiting requested review from onhate

Assignees

@leandroppf leandroppf

Labels
bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Adicionar currentColor no Select
2 participants
@leandroppf @YaGRRusso