Port the DEBUG hack to React 0.13.3 #2
Conversation
…s-debug.js, which are going to be a hybrid dev/prod build that is faster than the dev version but still has most of the production error messages
- use of factory on React.DOM members - use of analytics plugin (maybe don't need this...) Avoided (these are still __DEV__) - freezing objects - propType checking - lots of small checks like warnings of whether style names are valid.
…ets loaded into metaserver
…help from 1d0c1b1 to get the basic gulp setup (0.14 beta v2 code), and took a lot of dependency wrangling. `grunt extract-errors` should run the script now. I'm starting with a fresh codes.json because these will never match up with the official ones unfortunately. Things skipped: - travis integration. I don't know anything about travis so don't know if / how to hook this up for it. - inserting this as part of a full build process. It looks like it's a oneoff in master too fwiw
|
having a hard time telling: what is this 0.13-stable branch you want to merge into, and what commit are we based from? (We should be basing from tag v0.13.3) |
|
|
||
| To update: | ||
| * make your changes, then run `grunt build` | ||
| * `cp build/react-with-addons.js metaserver/metaserver/static/javascript/external/react-0.12.0.js` | ||
| * `cp build/react-with-addons.min.js metaserver/metaserver/static/javascript/external/react-0.12.0.min.js` | ||
| * `cp build/react-with-addons.js metaserver/metaserver/static/javascript/external/react-0.12.3.js` |
There was a problem hiding this comment.
this looks like a bug? should be react 0.13.3 not 0.12.3?
| @@ -142,7 +142,7 @@ ReactElement.prototype = { | |||
| _isReactElement: true | |||
| }; | |||
|
|
|||
| if (__DEV__) { | |||
| if (__DEBUG__) { | |||
|
went over everything else and it seems reasonable - my main concerns are just whether this enables proptype checking and object freezing for debug, since supposedly those two things are slow. Forward ports of my build system changes and error codes stuff look like nothing changed. Also want to know if we are based on the right commit. We should sort that out first. |
Instead we should use the official build for prod.
We probably want to include them later on since they're immensely useful for upgrading to future versions. But for the (at least) initial 0.13.3 we can live without them.
Any reason in particular why we'd want to base it on the (months older) 0.13.3 tag? Granted, I think most (if not all?) commits after that are for documentation, but it seemed to me like we'd want to base it off whatever was the most recent version of React 0.13? |
|
ah, I guess that's fine. I just figured we were already shipping react .13.3 in prod, so it would make sense to base from there. if you think newer is better / not risky, we can roll with it. |
|
Yeah. The 0.13-stable branch is still 0.13.3. And judging by the date match of the blog post announcing 0.13.3 and the latest commit on 0.13-stable, I think it's reasonable to assume that the "official" 0.13.3 version (i.e. the one we're already using) is built from the HEAD of the 0.13-stable branch. |
|
Looks good to me |
* remove old docs framey stuff * css tweak, tutorial rename, scrap old stuff * fix the tutorial links * broken link * a slew of broken links * all broken links up to the tips * redirects for all the tips * fix up prev/next links * fix error decoder * remove old folder * move addons to reference * Split Lists and Conditional Rendering (#2) * Split Lists and Conditional Rendering * Update lists-and-keys.md * move around some redirects * point to hello world rather than installation * tweak hello world text * make docs header point to hello world
[WIP] This attempts to port the production warnings we added to React 0.12 to React 0.13.
The WIP is because I haven't really had time to test this thoroughly yet. I wanted to submit the diff early so that the choice of warnings can be inspected.
Most of the changes merged fine without any major tweaks.